revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 16:52:41 +01:00
Code Issues Releases Wiki Activity

Use RemarkupControl in Differential inline comment UI

Browse source 
Summary: Fixes T4317. Update the "inline comment" control to a RemarkupControl. This could maybe use some padding/spacing/design touches eventually but seems OK for the moment.

Test Plan: {F101825}

Reviewers: chad, btrahan

Reviewed By: chad

CC: chad, aran

Maniphest Tasks: T4317

Differential Revision: https://secure.phabricator.com/D7969
This commit is contained in:
epriestley 2014-01-14 15:15:47 -08:00
parent 9f6aa3526a
commit 42d9fa34e2
3 changed files with 7 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/applications/differential/view/DifferentialInlineCommentEditView.php
View file

@ -104,16 +104,6 @@ final class DifferentialInlineCommentEditView extends AphrontView {
), ),
pht('Cancel')); pht('Cancel'));
$formatting = phutil_tag(
'a',
array(
'href' => PhabricatorEnv::getDoclink(
'article/Remarkup_Reference.html'),
'tabindex' => '-1',
'target' => '_blank',
),
pht('Formatting Reference'));
$title = phutil_tag( $title = phutil_tag(
'div', 'div',
array( array(
@ -134,7 +124,6 @@ final class DifferentialInlineCommentEditView extends AphrontView {
'class' => 'differential-inline-comment-edit-buttons', 'class' => 'differential-inline-comment-edit-buttons',
), ),
array( array(
$formatting,
$buttons, $buttons,
phutil_tag('div', array('style' => 'clear: both'), ''), phutil_tag('div', array('style' => 'clear: both'), ''),
)); ));

13
src/infrastructure/diff/PhabricatorInlineCommentController.php
View file

@ -235,14 +235,11 @@ abstract class PhabricatorInlineCommentController
} }
private function renderTextArea($text) { private function renderTextArea($text) {
return javelin_tag( return id(new PhabricatorRemarkupControl())
'textarea', ->setUser($this->getRequest()->getUser())
array( ->setSigil('differential-inline-comment-edit-textarea')
'class' => 'differential-inline-comment-edit-textarea', ->setName('text')
'sigil' => 'differential-inline-comment-edit-textarea', ->setValue($text);
'name' => 'text',
),
$text);
} }
} }

5
webroot/rsrc/css/application/differential/changeset-view.css
View file

@ -287,10 +287,9 @@ td.cov-X {
font-style: normal; font-style: normal;
} }
.differential-inline-comment-edit-body .aphront-form-input {
.differential-inline-comment-edit-textarea { margin: 0;
width: 100%; width: 100%;
height: 12em;
} }
.differential-changeset-buttons { .differential-changeset-buttons {