revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00
Code Issues Releases Wiki Activity

Fix an issue where Herald rules could fail to evaluate at post-commit time

Browse source 
Summary: Ref T13480. Some Herald fields need audit information, which recent changes to Herald adapters discarded. For now, just load it unconditionally.

Test Plan: Triggered an Audit-related rule locally.

Maniphest Tasks: T13480

Differential Revision: https://secure.phabricator.com/D20962
This commit is contained in:
epriestley 2020-02-03 05:04:01 -08:00
parent ccf28a8112
commit 42e46bbe5a
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/diffusion/herald/HeraldCommitAdapter.php
View file

@ -52,6 +52,7 @@ final class HeraldCommitAdapter
->withPHIDs(array($commit_phid)) ->withPHIDs(array($commit_phid))
->needCommitData(true) ->needCommitData(true)
->needIdentities(true) ->needIdentities(true)
->needAuditRequests(true)
->executeOne(); ->executeOne();
if (!$commit) { if (!$commit) {
throw new Exception( throw new Exception(