Add a "default view" policy to Differential

Summary:
Ref T603. Allows the Differential view policy to be configured with a default.

I've omitted "edit" because I want to wait and see how comment/comment-action policies work out. I could imagine locking "edit" down to only the owner at some point, and providing a wider "interact" capability, or something like that, which would cover accept/reject/commandeer. Users in this group could still edit indirectly by commandeering first.

Test Plan: Created new revisions from the CLI and conduit.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7269

src/__phutil_library_map__.php

@@ -309,6 +309,7 @@ phutil_register_library_map(array(
     'DifferentialBranchFieldSpecification' => 'applications/differential/field/specification/DifferentialBranchFieldSpecification.php',
     'DifferentialCCWelcomeMail' => 'applications/differential/mail/DifferentialCCWelcomeMail.php',
     'DifferentialCCsFieldSpecification' => 'applications/differential/field/specification/DifferentialCCsFieldSpecification.php',
+    'DifferentialCapabilityDefaultView' => 'applications/differential/capability/DifferentialCapabilityDefaultView.php',
     'DifferentialChangeType' => 'applications/differential/constants/DifferentialChangeType.php',
     'DifferentialChangeset' => 'applications/differential/storage/DifferentialChangeset.php',
     'DifferentialChangesetDetailView' => 'applications/differential/view/DifferentialChangesetDetailView.php',
@@ -2410,6 +2411,7 @@ phutil_register_library_map(array(
     'DifferentialBranchFieldSpecification' => 'DifferentialFieldSpecification',
     'DifferentialCCWelcomeMail' => 'DifferentialReviewRequestMail',
     'DifferentialCCsFieldSpecification' => 'DifferentialFieldSpecification',
+    'DifferentialCapabilityDefaultView' => 'PhabricatorPolicyCapability',
     'DifferentialChangeset' => 'DifferentialDAO',
     'DifferentialChangesetDetailView' => 'AphrontView',
     'DifferentialChangesetHTMLRenderer' => 'DifferentialChangesetRenderer',

src/applications/differential/application/PhabricatorApplicationDifferential.php

@@ -118,5 +118,14 @@ final class PhabricatorApplicationDifferential extends PhabricatorApplication {
     return $status;
   }
 
+  protected function getCustomCapabilities() {
+    return array(
+      DifferentialCapabilityDefaultView::CAPABILITY => array(
+        'caption' => pht(
+          'Default view policy for newly created revisions.')
+      ),
+    );
+  }
+
 }
 

src/applications/differential/capability/DifferentialCapabilityDefaultView.php

@@ -0,0 +1,16 @@
+<?php
+
+final class DifferentialCapabilityDefaultView
+  extends PhabricatorPolicyCapability {
+
+  const CAPABILITY = 'differential.default.view';
+
+  public function getCapabilityKey() {
+    return self::CAPABILITY;
+  }
+
+  public function getCapabilityName() {
+    return pht('Default View Policy');
+  }
+
+}

src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php

@@ -30,11 +30,12 @@ final class ConduitAPI_differential_getcommitmessage_Method
 
   protected function execute(ConduitAPIRequest $request) {
     $id = $request->getValue('revision_id');
+    $viewer = $request->getUser();
 
     if ($id) {
       $revision = id(new DifferentialRevisionQuery())
         ->withIDs(array($id))
-        ->setViewer($request->getUser())
+        ->setViewer($viewer)
         ->needRelationships(true)
         ->needReviewerStatus(true)
         ->executeOne();
@@ -43,8 +44,7 @@ final class ConduitAPI_differential_getcommitmessage_Method
         throw new ConduitException('ERR_NOT_FOUND');
       }
     } else {
-      $revision = new DifferentialRevision();
-      $revision->attachRelationships(array());
+      $revision = DifferentialRevision::initializeNewRevision($viewer);
     }
 
 
@@ -57,7 +57,7 @@ final class ConduitAPI_differential_getcommitmessage_Method
     $pro_tips = array();
 
     foreach ($aux_fields as $key => $aux_field) {
-      $aux_field->setUser($request->getUser());
+      $aux_field->setUser($viewer);
       $aux_field->setRevision($revision);
       $pro_tips[] = $aux_field->getCommitMessageTips();
       if (!$aux_field->shouldAppearOnCommitMessage()) {

src/applications/differential/controller/DifferentialRevisionEditController.php

@@ -32,8 +32,7 @@ final class DifferentialRevisionEditController extends DifferentialController {
         return new Aphront404Response();
       }
     } else {
-      $revision = new DifferentialRevision();
-      $revision->attachRelationships(array());
+      $revision = DifferentialRevision::initializeNewRevision($viewer);
     }
 
     $aux_fields = $this->loadAuxiliaryFields($revision);

src/applications/differential/editor/DifferentialRevisionEditor.php

@@ -40,10 +40,8 @@ final class DifferentialRevisionEditor extends PhabricatorEditor {
     DifferentialDiff $diff,
     PhabricatorUser $actor) {
 
-    $revision = new DifferentialRevision();
+    $revision = DifferentialRevision::initializeNewRevision($actor);
     $revision->setPHID($revision->generatePHID());
-    $revision->setAuthorPHID($actor->getPHID());
-    $revision->setStatus(ArcanistDifferentialRevisionStatus::NEEDS_REVIEW);
 
     $editor = new DifferentialRevisionEditor($revision);
     $editor->setActor($actor);
@@ -168,9 +166,6 @@ final class DifferentialRevisionEditor extends PhabricatorEditor {
     $revision = $this->getRevision();
 
     $is_new = $this->isNewRevision();
-    if ($is_new) {
-      $this->initializeNewRevision($revision);
-    }
 
     $revision->loadRelationships();
 
@@ -1101,29 +1096,6 @@ final class DifferentialRevisionEditor extends PhabricatorEditor {
     }
   }
 
-  private function initializeNewRevision(DifferentialRevision $revision) {
-    // These fields aren't nullable; set them to sensible defaults if they
-    // haven't been configured. We're just doing this so we can generate an
-    // ID for the revision if we don't have one already.
-    $revision->setLineCount(0);
-    if ($revision->getStatus() === null) {
-      $revision->setStatus(ArcanistDifferentialRevisionStatus::NEEDS_REVIEW);
-    }
-    if ($revision->getTitle() === null) {
-      $revision->setTitle('Untitled Revision');
-    }
-    if ($revision->getAuthorPHID() === null) {
-      $revision->setAuthorPHID($this->getActorPHID());
-    }
-    if ($revision->getSummary() === null) {
-      $revision->setSummary('');
-    }
-    if ($revision->getTestPlan() === null) {
-      $revision->setTestPlan('');
-    }
-  }
-
-
   /**
    * Try to move a revision to "accepted". We look for:
    *

src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php

@@ -6,7 +6,7 @@ final class PhabricatorDifferentialRevisionTestDataGenerator
   public function generate() {
     $author = $this->loadPhabrictorUser();
     $authorPHID = $author->getPHID();
-    $revision = new DifferentialRevision();
+    $revision = DifferentialRevision::initializeNewRevision($author);
     $revision->setTitle($this->generateTitle());
     $revision->setSummary($this->generateDescription());
     $revision->setTestPlan($this->generateDescription());

src/applications/differential/storage/DifferentialRevision.php

@@ -6,12 +6,12 @@ final class DifferentialRevision extends DifferentialDAO
     PhabricatorPolicyInterface,
     PhrequentTrackableInterface {
 
-  protected $title;
+  protected $title = '';
   protected $originalTitle;
   protected $status;
 
-  protected $summary;
-  protected $testPlan;
+  protected $summary = '';
+  protected $testPlan = '';
 
   protected $phid;
   protected $authorPHID;
@@ -19,7 +19,7 @@ final class DifferentialRevision extends DifferentialDAO
 
   protected $dateCommitted;
 
-  protected $lineCount;
+  protected $lineCount = 0;
   protected $attached = array();
 
   protected $mailKey;
@@ -44,6 +44,22 @@ final class DifferentialRevision extends DifferentialDAO
   const RELATION_REVIEWER     = 'revw';
   const RELATION_SUBSCRIBED   = 'subd';
 
+  public static function initializeNewRevision(PhabricatorUser $actor) {
+    $app = id(new PhabricatorApplicationQuery())
+      ->setViewer($actor)
+      ->withClasses(array('PhabricatorApplicationDifferential'))
+      ->executeOne();
+
+    $view_policy = $app->getPolicy(
+      DifferentialCapabilityDefaultView::CAPABILITY);
+
+    return id(new DifferentialRevision())
+      ->setViewPolicy($view_policy)
+      ->setAuthorPHID($actor->getPHID())
+      ->attachRelationships(array())
+      ->setStatus(ArcanistDifferentialRevisionStatus::NEEDS_REVIEW);
+  }
+
   public function getConfiguration() {
     return array(
       self::CONFIG_AUX_PHID => true,