From 44093da93c9acd3508a76632e77baf98f368c736 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Wed, 7 Jan 2015 07:33:43 +1100 Subject: [PATCH] Fix method visibility for `PhabricatorRepositoryCommitParserWorker` subclasses Summary: Ref T6822. Test Plan: Visual inspection. This method is only called from within the `PhabricatorRepositoryCommitParserWorker` class. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6822 Differential Revision: https://secure.phabricator.com/D11248 --- .../worker/PhabricatorRepositoryCommitHeraldWorker.php | 3 +-- .../PhabricatorRepositoryGitCommitMessageParserWorker.php | 2 +- ...PhabricatorRepositoryMercurialCommitMessageParserWorker.php | 2 +- .../PhabricatorRepositorySvnCommitMessageParserWorker.php | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php b/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php index 9d34cb3371..3654fe79b9 100644 --- a/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php +++ b/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php @@ -3,13 +3,12 @@ final class PhabricatorRepositoryCommitHeraldWorker extends PhabricatorRepositoryCommitParserWorker { - public function getRequiredLeaseTime() { // Herald rules may take a long time to process. return phutil_units('4 hours in seconds'); } - public function parseCommit( + protected function parseCommit( PhabricatorRepository $repository, PhabricatorRepositoryCommit $commit) { diff --git a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryGitCommitMessageParserWorker.php b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryGitCommitMessageParserWorker.php index 0789080a1b..15bd3a01b0 100644 --- a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryGitCommitMessageParserWorker.php +++ b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryGitCommitMessageParserWorker.php @@ -3,7 +3,7 @@ final class PhabricatorRepositoryGitCommitMessageParserWorker extends PhabricatorRepositoryCommitMessageParserWorker { - public function parseCommit( + protected function parseCommit( PhabricatorRepository $repository, PhabricatorRepositoryCommit $commit) { diff --git a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryMercurialCommitMessageParserWorker.php b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryMercurialCommitMessageParserWorker.php index a5bc1784a1..0a514955f6 100644 --- a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryMercurialCommitMessageParserWorker.php +++ b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryMercurialCommitMessageParserWorker.php @@ -3,7 +3,7 @@ final class PhabricatorRepositoryMercurialCommitMessageParserWorker extends PhabricatorRepositoryCommitMessageParserWorker { - public function parseCommit( + protected function parseCommit( PhabricatorRepository $repository, PhabricatorRepositoryCommit $commit) { diff --git a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositorySvnCommitMessageParserWorker.php b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositorySvnCommitMessageParserWorker.php index dad025dcc4..57a222190b 100644 --- a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositorySvnCommitMessageParserWorker.php +++ b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositorySvnCommitMessageParserWorker.php @@ -3,7 +3,7 @@ final class PhabricatorRepositorySvnCommitMessageParserWorker extends PhabricatorRepositoryCommitMessageParserWorker { - public function parseCommit( + protected function parseCommit( PhabricatorRepository $repository, PhabricatorRepositoryCommit $commit) {