From 4428a25a7cb488fa8905e3b61850ddf41e77bb47 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Thu, 3 Sep 2015 10:53:16 -0700 Subject: [PATCH] Minor Ponder Comment tweaks Summary: Makes the New Comment, See Comments more obviously placed to find. Test Plan: Review new CSS, answer question, comment, etc. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D14043 --- resources/celerity/map.php | 4 ++-- .../ponder/view/PonderFooterView.php | 4 ++-- .../css/application/ponder/ponder-view.css | 19 +++++++++++-------- 3 files changed, 15 insertions(+), 12 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index a076cf7814..a58be05060 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -93,7 +93,7 @@ return array( 'rsrc/css/application/policy/policy-edit.css' => '815c66f7', 'rsrc/css/application/policy/policy-transaction-detail.css' => '82100a43', 'rsrc/css/application/policy/policy.css' => '957ea14c', - 'rsrc/css/application/ponder/ponder-view.css' => 'bef48f86', + 'rsrc/css/application/ponder/ponder-view.css' => '7b0df4da', 'rsrc/css/application/projects/project-icon.css' => '4e3eaa5a', 'rsrc/css/application/releeph/releeph-core.css' => '9b3c5733', 'rsrc/css/application/releeph/releeph-preview-branch.css' => 'b7a6f4a5', @@ -811,7 +811,7 @@ return array( 'policy-css' => '957ea14c', 'policy-edit-css' => '815c66f7', 'policy-transaction-detail-css' => '82100a43', - 'ponder-view-css' => 'bef48f86', + 'ponder-view-css' => '7b0df4da', 'project-icon-css' => '4e3eaa5a', 'raphael-core' => '51ee6b43', 'raphael-g' => '40dde778', diff --git a/src/applications/ponder/view/PonderFooterView.php b/src/applications/ponder/view/PonderFooterView.php index b1f346b147..26e35ec45a 100644 --- a/src/applications/ponder/view/PonderFooterView.php +++ b/src/applications/ponder/view/PonderFooterView.php @@ -37,7 +37,7 @@ final class PonderFooterView extends AphrontTagView { if ($this->count == 0) { $icon = id(new PHUIIconView()) - ->setIconFont('fa-plus-circle msr'); + ->setIconFont('fa-comments msr'); $text = pht('Add a Comment'); } else { $icon = id(new PHUIIconView()) @@ -78,7 +78,7 @@ final class PonderFooterView extends AphrontTagView { $actions[] = $hide_action; $actions[] = $show_action; - return array($this->actions, $actions); + return array($actions, $this->actions); } } diff --git a/webroot/rsrc/css/application/ponder/ponder-view.css b/webroot/rsrc/css/application/ponder/ponder-view.css index 39d5c2a8f2..f1182d531c 100644 --- a/webroot/rsrc/css/application/ponder/ponder-view.css +++ b/webroot/rsrc/css/application/ponder/ponder-view.css @@ -54,30 +54,33 @@ } .ponder-footer-view { - margin: 0 4px -4px; - text-align: right; + margin: 0 0 -4px; + text-align: left; } .ponder-footer-view .ponder-footer-action { padding: 4px 8px; - margin-left: 8px; - color: {$bluetext}; + margin-right: 8px; + color: {$anchor}; display: inline-block; background-color: rgba(71, 87, 120, 0.06); - font-size: {$smallerfontsize}; } .ponder-footer-view .ponder-footer-action.ponder-footer-action-helpful { background-color: {$lightyellow}; + color: {$bluetext}; +} + +.ponder-footer-view .ponder-footer-action.ponder-footer-action-helpful + .phui-icon-view { + color: {$bluetext}; } .ponder-footer-view .ponder-footer-action .phui-icon-view { - color: {$bluetext}; - font-size: {$smallerfontsize}; + color: {$anchor}; } .ponder-footer-view a:hover { text-decoration: none; - color: {$darkbluetext}; background-color: rgba(71, 87, 120, 0.10); }