mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 00:42:41 +01:00
Fix PHP 8.1 "strlen(null)" exceptions which block rendering the "Add Panel to Dashboard" overlay dialog
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. Closes T15305 Test Plan: Applied these two changes (on top of `D25144`, `D25145`, `D25146`, `D25147`, `D25150`, `D25151`, `D25152`, `D25153`, `D25154`)) and "Use Results -> Add Panel to Dashboard" overlay dialog finally rendered in web browser. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15305 Differential Revision: https://we.phorge.it/D25155
This commit is contained in:
parent
1b82943419
commit
456ba873ca
1 changed files with 2 additions and 2 deletions
|
@ -13,12 +13,12 @@ final class PhabricatorDashboardQueryPanelInstallController
|
|||
$e_name = true;
|
||||
|
||||
$v_engine = $request->getStr('engine');
|
||||
if (!strlen($v_engine)) {
|
||||
if (!phutil_nonempty_string($v_engine)) {
|
||||
$v_engine = $request->getURIData('engineKey');
|
||||
}
|
||||
|
||||
$v_query = $request->getStr('query');
|
||||
if (!strlen($v_query)) {
|
||||
if (!phutil_nonempty_string($v_query)) {
|
||||
$v_query = $request->getURIData('queryKey');
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue