From 457503838f2e3f252324d6d1952bd951e44b2042 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Wed, 3 Jul 2013 09:23:16 -0700 Subject: [PATCH] Fix shadown on aphront filter viewy Summary: Fixes T3478, adds a wrap with a border. Test Plan: Reload page. Reviewers: epriestley CC: aran, Korvin Maniphest Tasks: T3478 Differential Revision: https://secure.phabricator.com/D6358 --- src/__celerity_resource_map__.php | 90 +++++++++---------- src/view/layout/AphrontListFilterView.php | 9 +- webroot/rsrc/css/aphront/list-filter-view.css | 7 +- 3 files changed, 58 insertions(+), 48 deletions(-) diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php index 006b862c2d..a5c10fd9c4 100644 --- a/src/__celerity_resource_map__.php +++ b/src/__celerity_resource_map__.php @@ -823,7 +823,7 @@ celerity_register_resource_map(array( ), 'aphront-list-filter-view-css' => array( - 'uri' => '/res/ac995ae2/rsrc/css/aphront/list-filter-view.css', + 'uri' => '/res/d7b529ce/rsrc/css/aphront/list-filter-view.css', 'type' => 'css', 'requires' => array( @@ -4073,7 +4073,7 @@ celerity_register_resource_map(array( ), array( 'packages' => array( - 'f38244f0' => + '9e452fba' => array( 'name' => 'core.pkg.css', 'symbols' => @@ -4121,7 +4121,7 @@ celerity_register_resource_map(array( 40 => 'phabricator-property-list-view-css', 41 => 'phabricator-tag-view-css', ), - 'uri' => '/res/pkg/f38244f0/core.pkg.css', + 'uri' => '/res/pkg/9e452fba/core.pkg.css', 'type' => 'css', ), 'f2ad0683' => @@ -4315,16 +4315,16 @@ celerity_register_resource_map(array( 'reverse' => array( 'aphront-attached-file-view-css' => 'adc3c36d', - 'aphront-dialog-view-css' => 'f38244f0', - 'aphront-error-view-css' => 'f38244f0', - 'aphront-form-view-css' => 'f38244f0', - 'aphront-list-filter-view-css' => 'f38244f0', - 'aphront-pager-view-css' => 'f38244f0', - 'aphront-panel-view-css' => 'f38244f0', - 'aphront-table-view-css' => 'f38244f0', - 'aphront-tokenizer-control-css' => 'f38244f0', - 'aphront-tooltip-css' => 'f38244f0', - 'aphront-typeahead-control-css' => 'f38244f0', + 'aphront-dialog-view-css' => '9e452fba', + 'aphront-error-view-css' => '9e452fba', + 'aphront-form-view-css' => '9e452fba', + 'aphront-list-filter-view-css' => '9e452fba', + 'aphront-pager-view-css' => '9e452fba', + 'aphront-panel-view-css' => '9e452fba', + 'aphront-table-view-css' => '9e452fba', + 'aphront-tokenizer-control-css' => '9e452fba', + 'aphront-tooltip-css' => '9e452fba', + 'aphront-typeahead-control-css' => '9e452fba', 'differential-changeset-view-css' => 'dd27a69b', 'differential-core-view-css' => 'dd27a69b', 'differential-inline-comment-editor' => '9488bb69', @@ -4338,7 +4338,7 @@ celerity_register_resource_map(array( 'differential-table-of-contents-css' => 'dd27a69b', 'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88', - 'global-drag-and-drop-css' => 'f38244f0', + 'global-drag-and-drop-css' => '9e452fba', 'inline-comment-summary-css' => 'dd27a69b', 'javelin-aphlict' => 'f2ad0683', 'javelin-behavior' => 'a9f14d76', @@ -4412,55 +4412,55 @@ celerity_register_resource_map(array( 'javelin-util' => 'a9f14d76', 'javelin-vector' => 'a9f14d76', 'javelin-workflow' => 'a9f14d76', - 'lightbox-attachment-css' => 'f38244f0', + 'lightbox-attachment-css' => '9e452fba', 'maniphest-task-summary-css' => 'adc3c36d', 'maniphest-transaction-detail-css' => 'adc3c36d', - 'phabricator-action-list-view-css' => 'f38244f0', - 'phabricator-application-launch-view-css' => 'f38244f0', + 'phabricator-action-list-view-css' => '9e452fba', + 'phabricator-application-launch-view-css' => '9e452fba', 'phabricator-busy' => 'f2ad0683', 'phabricator-content-source-view-css' => 'dd27a69b', - 'phabricator-core-css' => 'f38244f0', - 'phabricator-crumbs-view-css' => 'f38244f0', + 'phabricator-core-css' => '9e452fba', + 'phabricator-crumbs-view-css' => '9e452fba', 'phabricator-drag-and-drop-file-upload' => '9488bb69', 'phabricator-dropdown-menu' => 'f2ad0683', 'phabricator-file-upload' => 'f2ad0683', - 'phabricator-filetree-view-css' => 'f38244f0', - 'phabricator-flag-css' => 'f38244f0', - 'phabricator-form-view-css' => 'f38244f0', - 'phabricator-header-view-css' => 'f38244f0', + 'phabricator-filetree-view-css' => '9e452fba', + 'phabricator-flag-css' => '9e452fba', + 'phabricator-form-view-css' => '9e452fba', + 'phabricator-header-view-css' => '9e452fba', 'phabricator-hovercard' => 'f2ad0683', - 'phabricator-jump-nav' => 'f38244f0', + 'phabricator-jump-nav' => '9e452fba', 'phabricator-keyboard-shortcut' => 'f2ad0683', 'phabricator-keyboard-shortcut-manager' => 'f2ad0683', - 'phabricator-main-menu-view' => 'f38244f0', + 'phabricator-main-menu-view' => '9e452fba', 'phabricator-menu-item' => 'f2ad0683', - 'phabricator-nav-view-css' => 'f38244f0', + 'phabricator-nav-view-css' => '9e452fba', 'phabricator-notification' => 'f2ad0683', - 'phabricator-notification-css' => 'f38244f0', - 'phabricator-notification-menu-css' => 'f38244f0', - 'phabricator-object-item-list-view-css' => 'f38244f0', + 'phabricator-notification-css' => '9e452fba', + 'phabricator-notification-menu-css' => '9e452fba', + 'phabricator-object-item-list-view-css' => '9e452fba', 'phabricator-object-selector-css' => 'dd27a69b', 'phabricator-phtize' => 'f2ad0683', 'phabricator-prefab' => 'f2ad0683', 'phabricator-project-tag-css' => 'adc3c36d', - 'phabricator-property-list-view-css' => 'f38244f0', - 'phabricator-remarkup-css' => 'f38244f0', + 'phabricator-property-list-view-css' => '9e452fba', + 'phabricator-remarkup-css' => '9e452fba', 'phabricator-shaped-request' => '9488bb69', - 'phabricator-side-menu-view-css' => 'f38244f0', - 'phabricator-standard-page-view' => 'f38244f0', - 'phabricator-tag-view-css' => 'f38244f0', + 'phabricator-side-menu-view-css' => '9e452fba', + 'phabricator-standard-page-view' => '9e452fba', + 'phabricator-tag-view-css' => '9e452fba', 'phabricator-textareautils' => 'f2ad0683', 'phabricator-tooltip' => 'f2ad0683', - 'phabricator-transaction-view-css' => 'f38244f0', - 'phabricator-zindex-css' => 'f38244f0', - 'phui-button-css' => 'f38244f0', - 'phui-form-css' => 'f38244f0', - 'phui-icon-view-css' => 'f38244f0', - 'phui-spacing-css' => 'f38244f0', - 'sprite-apps-large-css' => 'f38244f0', - 'sprite-gradient-css' => 'f38244f0', - 'sprite-icons-css' => 'f38244f0', - 'sprite-menu-css' => 'f38244f0', - 'syntax-highlighting-css' => 'f38244f0', + 'phabricator-transaction-view-css' => '9e452fba', + 'phabricator-zindex-css' => '9e452fba', + 'phui-button-css' => '9e452fba', + 'phui-form-css' => '9e452fba', + 'phui-icon-view-css' => '9e452fba', + 'phui-spacing-css' => '9e452fba', + 'sprite-apps-large-css' => '9e452fba', + 'sprite-gradient-css' => '9e452fba', + 'sprite-icons-css' => '9e452fba', + 'sprite-menu-css' => '9e452fba', + 'syntax-highlighting-css' => '9e452fba', ), )); diff --git a/src/view/layout/AphrontListFilterView.php b/src/view/layout/AphrontListFilterView.php index 99a956f38a..11d6631214 100644 --- a/src/view/layout/AphrontListFilterView.php +++ b/src/view/layout/AphrontListFilterView.php @@ -100,12 +100,19 @@ final class AphrontListFilterView extends AphrontView { ); } - return phutil_tag( + $content = phutil_tag( 'div', array( 'class' => implode(' ', $classes), ), $content); + + return phutil_tag( + 'div', + array( + 'class' => 'aphront-list-filter-wrap' + ), + $content); } } diff --git a/webroot/rsrc/css/aphront/list-filter-view.css b/webroot/rsrc/css/aphront/list-filter-view.css index 8d054f039c..6e0eb3c23f 100644 --- a/webroot/rsrc/css/aphront/list-filter-view.css +++ b/webroot/rsrc/css/aphront/list-filter-view.css @@ -2,13 +2,16 @@ * @provides aphront-list-filter-view-css */ -.aphront-list-filter-view { +.aphront-list-filter-wrap { border-left: 1px solid #e7e7e7; border-right: 1px solid #e7e7e7; border-bottom: 1px solid #c0c5d1; + margin: 0 20px; +} + +.aphront-list-filter-view { background: #fff; - margin: 0 20px; padding: 0; box-shadow: 0 1px 2px rgba(0,0,0,0.2); }