Restore "Limit" to dashboard Query panels

Summary: See PHI1220. Ref T13272. I accidentally left the ability to set a query limit behind when updating this.

Test Plan: Edited a query panel, set/removed the limit, tried to set an invalid limit.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13272

Differential Revision: https://secure.phabricator.com/D20472

src/__phutil_library_map__.php

@@ -3007,6 +3007,7 @@ phutil_register_library_map(array(
     'PhabricatorDashboardQueryPanelApplicationEditField' => 'applications/dashboard/editfield/PhabricatorDashboardQueryPanelApplicationEditField.php',
     'PhabricatorDashboardQueryPanelApplicationTransaction' => 'applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelApplicationTransaction.php',
     'PhabricatorDashboardQueryPanelInstallController' => 'applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php',
+    'PhabricatorDashboardQueryPanelLimitTransaction' => 'applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelLimitTransaction.php',
     'PhabricatorDashboardQueryPanelQueryEditField' => 'applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php',
     'PhabricatorDashboardQueryPanelQueryTransaction' => 'applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelQueryTransaction.php',
     'PhabricatorDashboardQueryPanelType' => 'applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php',
@@ -9045,6 +9046,7 @@ phutil_register_library_map(array(
     'PhabricatorDashboardQueryPanelApplicationEditField' => 'PhabricatorEditField',
     'PhabricatorDashboardQueryPanelApplicationTransaction' => 'PhabricatorDashboardPanelPropertyTransaction',
     'PhabricatorDashboardQueryPanelInstallController' => 'PhabricatorDashboardController',
+    'PhabricatorDashboardQueryPanelLimitTransaction' => 'PhabricatorDashboardPanelPropertyTransaction',
     'PhabricatorDashboardQueryPanelQueryEditField' => 'PhabricatorEditField',
     'PhabricatorDashboardQueryPanelQueryTransaction' => 'PhabricatorDashboardPanelPropertyTransaction',
     'PhabricatorDashboardQueryPanelType' => 'PhabricatorDashboardPanelType',

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

@@ -41,9 +41,17 @@ final class PhabricatorDashboardQueryPanelType
           PhabricatorDashboardQueryPanelQueryTransaction::TRANSACTIONTYPE)
         ->setValue($panel->getProperty('key', ''));
 
+    $limit_field = id(new PhabricatorIntEditField())
+      ->setKey('limit')
+      ->setLabel(pht('Limit'))
+      ->setTransactionType(
+        PhabricatorDashboardQueryPanelLimitTransaction::TRANSACTIONTYPE)
+      ->setValue($panel->getProperty('limit'));
+
     return array(
       $application_field,
       $query_field,
+      $limit_field,
     );
   }
 

src/applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelLimitTransaction.php

@@ -0,0 +1,43 @@
+<?php
+
+final class PhabricatorDashboardQueryPanelLimitTransaction
+  extends PhabricatorDashboardPanelPropertyTransaction {
+
+  const TRANSACTIONTYPE = 'search.limit';
+
+  protected function getPropertyKey() {
+    return 'limit';
+  }
+
+  public function generateNewValue($object, $value) {
+    if (!$value) {
+      return null;
+    }
+
+    return $value;
+  }
+
+  public function validateTransactions($object, array $xactions) {
+    $errors = array();
+
+    $old_value = $object->getProperty($this->getPropertyKey());
+    foreach ($xactions as $xaction) {
+      $new_value = $xaction->getNewValue();
+
+      if ($new_value === $old_value) {
+        continue;
+      }
+
+      if ($new_value < 0) {
+        $errors[] = $this->newInvalidError(
+          pht(
+            'Query result limit must be empty, or at least 1.'),
+          $xaction);
+        continue;
+      }
+    }
+
+    return $errors;
+  }
+
+}

src/applications/transactions/editfield/PhabricatorIntEditField.php

@@ -7,6 +7,10 @@ final class PhabricatorIntEditField
     return new AphrontFormTextControl();
   }
 
+  protected function newHTTPParameterType() {
+    return new AphrontIntHTTPParameterType();
+  }
+
   protected function newConduitParameterType() {
     return new ConduitIntParameterType();
   }