revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 05:12:41 +01:00
Code Issues Releases Wiki Activity

Fix Diffusion crash

Browse source 
Summary: This fixes a crash that happens when visiting Diffusion pages due to an undefined variable.  `$title` is only defined if it has a status to show, but then it uses it anyway and fails.

Test Plan: Pages stopped crashing and people stopped complaining.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D8906
This commit is contained in:
James Rhodes 2014-04-29 19:06:52 -07:00 committed by epriestley
parent 31580f19d9
commit 466af33147
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/diffusion/controller/DiffusionController.php
View file

@ -255,6 +255,7 @@ abstract class DiffusionController extends PhabricatorController {
private function buildRepositoryWarning(PhabricatorRepository $repository) { private function buildRepositoryWarning(PhabricatorRepository $repository) {
$error_view = null; $error_view = null;
$title = null;
if ($repository->isImporting()) { if ($repository->isImporting()) {
$title = pht('This repository is still importing.'); $title = pht('This repository is still importing.');
$body = pht('Things may not work properly until the import finishes.'); $body = pht('Things may not work properly until the import finishes.');