From 4672705c22c6cc447df8ebecd681f0e17092eec4 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Tue, 11 Jun 2013 20:53:55 -0700 Subject: [PATCH] Tweak audit status colors. Summary: Fixes T3242. Changes the red and orange objects to match the transactions. Also adds a highlight color to 'cards'. Test Plan: Review my audits in my sandbox Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T3242 Differential Revision: https://secure.phabricator.com/D6184 --- src/__celerity_resource_map__.php | 90 +++++++++---------- .../PhabricatorAuditStatusConstants.php | 4 +- .../audit/view/PhabricatorAuditListView.php | 2 +- .../phabricator-object-item-list-view.css | 8 +- 4 files changed, 55 insertions(+), 49 deletions(-) diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php index 2fae99fa88..07f815c578 100644 --- a/src/__celerity_resource_map__.php +++ b/src/__celerity_resource_map__.php @@ -3233,7 +3233,7 @@ celerity_register_resource_map(array( ), 'phabricator-object-item-list-view-css' => array( - 'uri' => '/res/b9f7acb9/rsrc/css/layout/phabricator-object-item-list-view.css', + 'uri' => '/res/4ba9eeaf/rsrc/css/layout/phabricator-object-item-list-view.css', 'type' => 'css', 'requires' => array( @@ -4048,7 +4048,7 @@ celerity_register_resource_map(array( ), array( 'packages' => array( - '927f8f60' => + '1378b4c7' => array( 'name' => 'core.pkg.css', 'symbols' => @@ -4096,7 +4096,7 @@ celerity_register_resource_map(array( 40 => 'phabricator-property-list-view-css', 41 => 'phabricator-tag-view-css', ), - 'uri' => '/res/pkg/927f8f60/core.pkg.css', + 'uri' => '/res/pkg/1378b4c7/core.pkg.css', 'type' => 'css', ), 'f2ad0683' => @@ -4290,16 +4290,16 @@ celerity_register_resource_map(array( 'reverse' => array( 'aphront-attached-file-view-css' => 'a7ca34a9', - 'aphront-dialog-view-css' => '927f8f60', - 'aphront-error-view-css' => '927f8f60', - 'aphront-form-view-css' => '927f8f60', - 'aphront-list-filter-view-css' => '927f8f60', - 'aphront-pager-view-css' => '927f8f60', - 'aphront-panel-view-css' => '927f8f60', - 'aphront-table-view-css' => '927f8f60', - 'aphront-tokenizer-control-css' => '927f8f60', - 'aphront-tooltip-css' => '927f8f60', - 'aphront-typeahead-control-css' => '927f8f60', + 'aphront-dialog-view-css' => '1378b4c7', + 'aphront-error-view-css' => '1378b4c7', + 'aphront-form-view-css' => '1378b4c7', + 'aphront-list-filter-view-css' => '1378b4c7', + 'aphront-pager-view-css' => '1378b4c7', + 'aphront-panel-view-css' => '1378b4c7', + 'aphront-table-view-css' => '1378b4c7', + 'aphront-tokenizer-control-css' => '1378b4c7', + 'aphront-tooltip-css' => '1378b4c7', + 'aphront-typeahead-control-css' => '1378b4c7', 'differential-changeset-view-css' => 'dd27a69b', 'differential-core-view-css' => 'dd27a69b', 'differential-inline-comment-editor' => '9488bb69', @@ -4313,7 +4313,7 @@ celerity_register_resource_map(array( 'differential-table-of-contents-css' => 'dd27a69b', 'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88', - 'global-drag-and-drop-css' => '927f8f60', + 'global-drag-and-drop-css' => '1378b4c7', 'inline-comment-summary-css' => 'dd27a69b', 'javelin-aphlict' => 'f2ad0683', 'javelin-behavior' => 'a9f14d76', @@ -4387,55 +4387,55 @@ celerity_register_resource_map(array( 'javelin-util' => 'a9f14d76', 'javelin-vector' => 'a9f14d76', 'javelin-workflow' => 'a9f14d76', - 'lightbox-attachment-css' => '927f8f60', + 'lightbox-attachment-css' => '1378b4c7', 'maniphest-task-summary-css' => 'a7ca34a9', 'maniphest-transaction-detail-css' => 'a7ca34a9', - 'phabricator-action-list-view-css' => '927f8f60', - 'phabricator-application-launch-view-css' => '927f8f60', + 'phabricator-action-list-view-css' => '1378b4c7', + 'phabricator-application-launch-view-css' => '1378b4c7', 'phabricator-busy' => 'f2ad0683', 'phabricator-content-source-view-css' => 'dd27a69b', - 'phabricator-core-buttons-css' => '927f8f60', - 'phabricator-core-css' => '927f8f60', - 'phabricator-crumbs-view-css' => '927f8f60', + 'phabricator-core-buttons-css' => '1378b4c7', + 'phabricator-core-css' => '1378b4c7', + 'phabricator-crumbs-view-css' => '1378b4c7', 'phabricator-drag-and-drop-file-upload' => '9488bb69', 'phabricator-dropdown-menu' => 'f2ad0683', 'phabricator-file-upload' => 'f2ad0683', - 'phabricator-filetree-view-css' => '927f8f60', - 'phabricator-flag-css' => '927f8f60', - 'phabricator-form-view-css' => '927f8f60', - 'phabricator-header-view-css' => '927f8f60', + 'phabricator-filetree-view-css' => '1378b4c7', + 'phabricator-flag-css' => '1378b4c7', + 'phabricator-form-view-css' => '1378b4c7', + 'phabricator-header-view-css' => '1378b4c7', 'phabricator-hovercard' => 'f2ad0683', - 'phabricator-jump-nav' => '927f8f60', + 'phabricator-jump-nav' => '1378b4c7', 'phabricator-keyboard-shortcut' => 'f2ad0683', 'phabricator-keyboard-shortcut-manager' => 'f2ad0683', - 'phabricator-main-menu-view' => '927f8f60', + 'phabricator-main-menu-view' => '1378b4c7', 'phabricator-menu-item' => 'f2ad0683', - 'phabricator-nav-view-css' => '927f8f60', + 'phabricator-nav-view-css' => '1378b4c7', 'phabricator-notification' => 'f2ad0683', - 'phabricator-notification-css' => '927f8f60', - 'phabricator-notification-menu-css' => '927f8f60', - 'phabricator-object-item-list-view-css' => '927f8f60', + 'phabricator-notification-css' => '1378b4c7', + 'phabricator-notification-menu-css' => '1378b4c7', + 'phabricator-object-item-list-view-css' => '1378b4c7', 'phabricator-object-selector-css' => 'dd27a69b', 'phabricator-phtize' => 'f2ad0683', 'phabricator-prefab' => 'f2ad0683', 'phabricator-project-tag-css' => 'a7ca34a9', - 'phabricator-property-list-view-css' => '927f8f60', - 'phabricator-remarkup-css' => '927f8f60', + 'phabricator-property-list-view-css' => '1378b4c7', + 'phabricator-remarkup-css' => '1378b4c7', 'phabricator-shaped-request' => '9488bb69', - 'phabricator-side-menu-view-css' => '927f8f60', - 'phabricator-standard-page-view' => '927f8f60', - 'phabricator-tag-view-css' => '927f8f60', + 'phabricator-side-menu-view-css' => '1378b4c7', + 'phabricator-standard-page-view' => '1378b4c7', + 'phabricator-tag-view-css' => '1378b4c7', 'phabricator-textareautils' => 'f2ad0683', 'phabricator-tooltip' => 'f2ad0683', - 'phabricator-transaction-view-css' => '927f8f60', - 'phabricator-zindex-css' => '927f8f60', - 'phui-form-css' => '927f8f60', - 'phui-icon-view-css' => '927f8f60', - 'spacing-css' => '927f8f60', - 'sprite-apps-large-css' => '927f8f60', - 'sprite-gradient-css' => '927f8f60', - 'sprite-icons-css' => '927f8f60', - 'sprite-menu-css' => '927f8f60', - 'syntax-highlighting-css' => '927f8f60', + 'phabricator-transaction-view-css' => '1378b4c7', + 'phabricator-zindex-css' => '1378b4c7', + 'phui-form-css' => '1378b4c7', + 'phui-icon-view-css' => '1378b4c7', + 'spacing-css' => '1378b4c7', + 'sprite-apps-large-css' => '1378b4c7', + 'sprite-gradient-css' => '1378b4c7', + 'sprite-icons-css' => '1378b4c7', + 'sprite-menu-css' => '1378b4c7', + 'syntax-highlighting-css' => '1378b4c7', ), )); diff --git a/src/applications/audit/constants/PhabricatorAuditStatusConstants.php b/src/applications/audit/constants/PhabricatorAuditStatusConstants.php index 70a244a9de..8d8ce45e68 100644 --- a/src/applications/audit/constants/PhabricatorAuditStatusConstants.php +++ b/src/applications/audit/constants/PhabricatorAuditStatusConstants.php @@ -35,10 +35,10 @@ final class PhabricatorAuditStatusConstants { public static function getStatusColor($code) { switch ($code) { case self::CONCERNED: - $color = 'orange'; + $color = 'red'; break; case self::AUDIT_REQUIRED: - $color = 'red'; + $color = 'orange'; break; default: $color = null; diff --git a/src/applications/audit/view/PhabricatorAuditListView.php b/src/applications/audit/view/PhabricatorAuditListView.php index b11f705c2f..120e292fd0 100644 --- a/src/applications/audit/view/PhabricatorAuditListView.php +++ b/src/applications/audit/view/PhabricatorAuditListView.php @@ -146,7 +146,7 @@ final class PhabricatorAuditListView extends AphrontView { ->addByline(pht('Auditor: %s', $auditor_handle->renderLink())); if (array_key_exists($audit->getID(), $this->getHighlightedAudits())) { - $item->setBarColor('yellow'); + $item->setEffect('highlighted'); } $list->addItem($item); diff --git a/webroot/rsrc/css/layout/phabricator-object-item-list-view.css b/webroot/rsrc/css/layout/phabricator-object-item-list-view.css index d936cc6954..2ad4d08fe9 100644 --- a/webroot/rsrc/css/layout/phabricator-object-item-list-view.css +++ b/webroot/rsrc/css/layout/phabricator-object-item-list-view.css @@ -345,7 +345,13 @@ */ .phabricator-object-item-highlighted { - background: #ffffb2; + background: rgb(253, 255, 221); +} + +.phabricator-object-list-cards + .phabricator-object-item.phabricator-object-item-highlighted { + background-image: linear-gradient(to bottom, rgb(253, 255, 221), rgb(243, 245, 206)); + background-image: -webkit-linear-gradient(top, rgb(253, 255, 221), rgb(243, 245, 206)); } .phabricator-object-item-selected {