revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-10 23:01:04 +01:00
Code Issues Releases Wiki Activity

Make aphront-side-nav more clear re what's a link

Browse source 
Summary:
Create a visual hierarchy with the <span>s and <a>s in the aphront-side-nav
so people don't try to click on a span thinking it's a link. This is to
help specifically with the case of the "All Revisions" header on the
differential revision list page - I've had a few people ask about that
broken link.

Test Plan:
Loaded the differential revision list view and the maniphest task list
view to check that their left-hand navs look ok (did this in ff8 on ubuntu
11.10).

Reviewers: epriestley, jungejason, btrahan

Reviewed By: jungejason

CC: aran, jungejason, epriestley

Differential Revision: https://secure.phabricator.com/D1303
This commit is contained in:
Nick Harper 2012-01-03 23:56:51 -08:00
parent d43dec1d12
commit 468d2eaa10
2 changed files with 92 additions and 77 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

164
src/__celerity_resource_map__.php
View file

@ -126,7 +126,7 @@ celerity_register_resource_map(array(
), ),
'aphront-side-nav-view-css' => 'aphront-side-nav-view-css' =>
array( array(
'uri' => '/res/f92966bd/rsrc/css/aphront/side-nav-view.css', 'uri' => '/res/42f70a69/rsrc/css/aphront/side-nav-view.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(
@ -804,6 +804,17 @@ celerity_register_resource_map(array(
), ),
'disk' => '/rsrc/js/javelin/ext/fx/Color.js', 'disk' => '/rsrc/js/javelin/ext/fx/Color.js',
), ),
'javelin-cookie' =>
array(
'uri' => '/res/a9cddab0/rsrc/js/javelin/lib/Cookie.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/lib/Cookie.js',
),
'javelin-dom' => 'javelin-dom' =>
array( array(
'uri' => '/res/b2e8a5b6/rsrc/js/javelin/lib/DOM.js', 'uri' => '/res/b2e8a5b6/rsrc/js/javelin/lib/DOM.js',
@ -933,6 +944,15 @@ celerity_register_resource_map(array(
), ),
'disk' => '/rsrc/js/javelin/ext/reactor/dom/RDOM.js', 'disk' => '/rsrc/js/javelin/ext/reactor/dom/RDOM.js',
), ),
0 =>
array(
'uri' => '/res/936e8e81/rsrc/js/javelin/docs/onload.js',
'type' => 'js',
'requires' =>
array(
),
'disk' => '/rsrc/js/javelin/docs/onload.js',
),
'javelin-reactor-node-calmer' => 'javelin-reactor-node-calmer' =>
array( array(
'uri' => '/res/5a35920a/rsrc/js/javelin/ext/reactor/core/ReactorNodeCalmer.js', 'uri' => '/res/5a35920a/rsrc/js/javelin/ext/reactor/core/ReactorNodeCalmer.js',
@ -960,7 +980,7 @@ celerity_register_resource_map(array(
), ),
'javelin-request' => 'javelin-request' =>
array( array(
'uri' => '/res/8d371c9b/rsrc/js/javelin/lib/Request.js', 'uri' => '/res/b3257b7d/rsrc/js/javelin/lib/Request.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
@ -969,6 +989,7 @@ celerity_register_resource_map(array(
2 => 'javelin-util', 2 => 'javelin-util',
3 => 'javelin-behavior', 3 => 'javelin-behavior',
4 => 'javelin-json', 4 => 'javelin-json',
5 => 'javelin-dom',
), ),
'disk' => '/rsrc/js/javelin/lib/Request.js', 'disk' => '/rsrc/js/javelin/lib/Request.js',
), ),
@ -987,7 +1008,7 @@ celerity_register_resource_map(array(
), ),
'javelin-stratcom' => 'javelin-stratcom' =>
array( array(
'uri' => '/res/92eb2fa0/rsrc/js/javelin/core/Stratcom.js', 'uri' => '/res/d7a3d1e9/rsrc/js/javelin/core/Stratcom.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
@ -1277,17 +1298,6 @@ celerity_register_resource_map(array(
), ),
'disk' => '/rsrc/css/application/contentsource/content-source-view.css', 'disk' => '/rsrc/css/application/contentsource/content-source-view.css',
), ),
0 =>
array(
'uri' => '/res/b6096fdd/rsrc/js/javelin/lib/__tests__/URI.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-uri',
1 => 'javelin-php-serializer',
),
'disk' => '/rsrc/js/javelin/lib/__tests__/URI.js',
),
'phabricator-core-buttons-css' => 'phabricator-core-buttons-css' =>
array( array(
'uri' => '/res/3059cf79/rsrc/css/core/buttons.css', 'uri' => '/res/3059cf79/rsrc/css/core/buttons.css',
@ -1652,25 +1662,6 @@ celerity_register_resource_map(array(
'uri' => '/res/pkg/03ef179e/diffusion.pkg.css', 'uri' => '/res/pkg/03ef179e/diffusion.pkg.css',
'type' => 'css', 'type' => 'css',
), ),
'22c00e0e' =>
array(
'name' => 'javelin.pkg.js',
'symbols' =>
array(
0 => 'javelin-util',
1 => 'javelin-install',
2 => 'javelin-event',
3 => 'javelin-stratcom',
4 => 'javelin-behavior',
5 => 'javelin-request',
6 => 'javelin-vector',
7 => 'javelin-dom',
8 => 'javelin-json',
9 => 'javelin-uri',
),
'uri' => '/res/pkg/22c00e0e/javelin.pkg.js',
'type' => 'js',
),
'4e7acf1a' => '4e7acf1a' =>
array( array(
'name' => 'core.pkg.js', 'name' => 'core.pkg.js',
@ -1713,29 +1704,24 @@ celerity_register_resource_map(array(
'uri' => '/res/pkg/6d89c54c/differential.pkg.js', 'uri' => '/res/pkg/6d89c54c/differential.pkg.js',
'type' => 'js', 'type' => 'js',
), ),
'831e959b' => 'b164acea' =>
array( array(
'name' => 'core.pkg.css', 'name' => 'javelin.pkg.js',
'symbols' => 'symbols' =>
array( array(
0 => 'phabricator-core-css', 0 => 'javelin-util',
1 => 'phabricator-core-buttons-css', 1 => 'javelin-install',
2 => 'phabricator-standard-page-view', 2 => 'javelin-event',
3 => 'aphront-dialog-view-css', 3 => 'javelin-stratcom',
4 => 'aphront-form-view-css', 4 => 'javelin-behavior',
5 => 'aphront-panel-view-css', 5 => 'javelin-request',
6 => 'aphront-side-nav-view-css', 6 => 'javelin-vector',
7 => 'aphront-table-view-css', 7 => 'javelin-dom',
8 => 'aphront-crumbs-view-css', 8 => 'javelin-json',
9 => 'aphront-tokenizer-control-css', 9 => 'javelin-uri',
10 => 'aphront-typeahead-control-css',
11 => 'aphront-list-filter-view-css',
12 => 'phabricator-directory-css',
13 => 'phabricator-remarkup-css',
14 => 'syntax-highlighting-css',
), ),
'uri' => '/res/pkg/831e959b/core.pkg.css', 'uri' => '/res/pkg/b164acea/javelin.pkg.js',
'type' => 'css', 'type' => 'js',
), ),
'bbe7e6f7' => 'bbe7e6f7' =>
array( array(
@ -1774,19 +1760,43 @@ celerity_register_resource_map(array(
'uri' => '/res/pkg/e4f8b52c/differential.pkg.css', 'uri' => '/res/pkg/e4f8b52c/differential.pkg.css',
'type' => 'css', 'type' => 'css',
), ),
'f3884b93' =>
array(
'name' => 'core.pkg.css',
'symbols' =>
array(
0 => 'phabricator-core-css',
1 => 'phabricator-core-buttons-css',
2 => 'phabricator-standard-page-view',
3 => 'aphront-dialog-view-css',
4 => 'aphront-form-view-css',
5 => 'aphront-panel-view-css',
6 => 'aphront-side-nav-view-css',
7 => 'aphront-table-view-css',
8 => 'aphront-crumbs-view-css',
9 => 'aphront-tokenizer-control-css',
10 => 'aphront-typeahead-control-css',
11 => 'aphront-list-filter-view-css',
12 => 'phabricator-directory-css',
13 => 'phabricator-remarkup-css',
14 => 'syntax-highlighting-css',
),
'uri' => '/res/pkg/f3884b93/core.pkg.css',
'type' => 'css',
),
), ),
'reverse' => 'reverse' =>
array( array(
'aphront-crumbs-view-css' => '831e959b', 'aphront-crumbs-view-css' => 'f3884b93',
'aphront-dialog-view-css' => '831e959b', 'aphront-dialog-view-css' => 'f3884b93',
'aphront-form-view-css' => '831e959b', 'aphront-form-view-css' => 'f3884b93',
'aphront-headsup-action-list-view-css' => 'e4f8b52c', 'aphront-headsup-action-list-view-css' => 'e4f8b52c',
'aphront-list-filter-view-css' => '831e959b', 'aphront-list-filter-view-css' => 'f3884b93',
'aphront-panel-view-css' => '831e959b', 'aphront-panel-view-css' => 'f3884b93',
'aphront-side-nav-view-css' => '831e959b', 'aphront-side-nav-view-css' => 'f3884b93',
'aphront-table-view-css' => '831e959b', 'aphront-table-view-css' => 'f3884b93',
'aphront-tokenizer-control-css' => '831e959b', 'aphront-tokenizer-control-css' => 'f3884b93',
'aphront-typeahead-control-css' => '831e959b', 'aphront-typeahead-control-css' => 'f3884b93',
'differential-changeset-view-css' => 'e4f8b52c', 'differential-changeset-view-css' => 'e4f8b52c',
'differential-core-view-css' => 'e4f8b52c', 'differential-core-view-css' => 'e4f8b52c',
'differential-inline-comment-editor' => '6d89c54c', 'differential-inline-comment-editor' => '6d89c54c',
@ -1798,7 +1808,7 @@ celerity_register_resource_map(array(
'differential-revision-history-css' => 'e4f8b52c', 'differential-revision-history-css' => 'e4f8b52c',
'differential-table-of-contents-css' => 'e4f8b52c', 'differential-table-of-contents-css' => 'e4f8b52c',
'diffusion-commit-view-css' => '03ef179e', 'diffusion-commit-view-css' => '03ef179e',
'javelin-behavior' => '22c00e0e', 'javelin-behavior' => 'b164acea',
'javelin-behavior-aphront-basic-tokenizer' => 'bbe7e6f7', 'javelin-behavior-aphront-basic-tokenizer' => 'bbe7e6f7',
'javelin-behavior-aphront-drag-and-drop' => '6d89c54c', 'javelin-behavior-aphront-drag-and-drop' => '6d89c54c',
'javelin-behavior-aphront-drag-and-drop-textarea' => '6d89c54c', 'javelin-behavior-aphront-drag-and-drop-textarea' => '6d89c54c',
@ -1817,34 +1827,34 @@ celerity_register_resource_map(array(
'javelin-behavior-phabricator-watch-anchor' => '4e7acf1a', 'javelin-behavior-phabricator-watch-anchor' => '4e7acf1a',
'javelin-behavior-refresh-csrf' => '4e7acf1a', 'javelin-behavior-refresh-csrf' => '4e7acf1a',
'javelin-behavior-workflow' => '4e7acf1a', 'javelin-behavior-workflow' => '4e7acf1a',
'javelin-dom' => '22c00e0e', 'javelin-dom' => 'b164acea',
'javelin-event' => '22c00e0e', 'javelin-event' => 'b164acea',
'javelin-install' => '22c00e0e', 'javelin-install' => 'b164acea',
'javelin-json' => '22c00e0e', 'javelin-json' => 'b164acea',
'javelin-mask' => '4e7acf1a', 'javelin-mask' => '4e7acf1a',
'javelin-request' => '22c00e0e', 'javelin-request' => 'b164acea',
'javelin-stratcom' => '22c00e0e', 'javelin-stratcom' => 'b164acea',
'javelin-tokenizer' => 'bbe7e6f7', 'javelin-tokenizer' => 'bbe7e6f7',
'javelin-typeahead' => 'bbe7e6f7', 'javelin-typeahead' => 'bbe7e6f7',
'javelin-typeahead-normalizer' => 'bbe7e6f7', 'javelin-typeahead-normalizer' => 'bbe7e6f7',
'javelin-typeahead-ondemand-source' => 'bbe7e6f7', 'javelin-typeahead-ondemand-source' => 'bbe7e6f7',
'javelin-typeahead-preloaded-source' => 'bbe7e6f7', 'javelin-typeahead-preloaded-source' => 'bbe7e6f7',
'javelin-typeahead-source' => 'bbe7e6f7', 'javelin-typeahead-source' => 'bbe7e6f7',
'javelin-uri' => '22c00e0e', 'javelin-uri' => 'b164acea',
'javelin-util' => '22c00e0e', 'javelin-util' => 'b164acea',
'javelin-vector' => '22c00e0e', 'javelin-vector' => 'b164acea',
'javelin-workflow' => '4e7acf1a', 'javelin-workflow' => '4e7acf1a',
'phabricator-content-source-view-css' => 'e4f8b52c', 'phabricator-content-source-view-css' => 'e4f8b52c',
'phabricator-core-buttons-css' => '831e959b', 'phabricator-core-buttons-css' => 'f3884b93',
'phabricator-core-css' => '831e959b', 'phabricator-core-css' => 'f3884b93',
'phabricator-directory-css' => '831e959b', 'phabricator-directory-css' => 'f3884b93',
'phabricator-drag-and-drop-file-upload' => '6d89c54c', 'phabricator-drag-and-drop-file-upload' => '6d89c54c',
'phabricator-keyboard-shortcut' => '4e7acf1a', 'phabricator-keyboard-shortcut' => '4e7acf1a',
'phabricator-keyboard-shortcut-manager' => '4e7acf1a', 'phabricator-keyboard-shortcut-manager' => '4e7acf1a',
'phabricator-object-selector-css' => 'e4f8b52c', 'phabricator-object-selector-css' => 'e4f8b52c',
'phabricator-remarkup-css' => '831e959b', 'phabricator-remarkup-css' => 'f3884b93',
'phabricator-shaped-request' => '6d89c54c', 'phabricator-shaped-request' => '6d89c54c',
'phabricator-standard-page-view' => '831e959b', 'phabricator-standard-page-view' => 'f3884b93',
'syntax-highlighting-css' => '831e959b', 'syntax-highlighting-css' => 'f3884b93',
), ),
)); ));

5
webroot/rsrc/css/aphront/side-nav-view.css
View file

@ -27,6 +27,11 @@ th.aphront-side-nav-navigation span {
text-decoration: none; text-decoration: none;
} }
th.aphront-side-nav-navigation span {
padding-left: 12px;
padding-top: 6px;
}
th.aphront-side-nav-navigation a:hover { th.aphront-side-nav-navigation a:hover {
text-decoration: none; text-decoration: none;
background: #f3f3f9; background: #f3f3f9;