mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 08:52:39 +01:00
Releeph: use relative URIs
Summary: I used the `PhabricatorEnv::getProductionURI()` in too many places to build Releeph URIs. The only places that should need full URIs are the links generated for Releeph emails, and in Conduit responses that link to Releeph objects. Test Plan: - Grep for `getProductionURI()` in Releeph, and make sure only sensible, non-DOM building places use it. - Inspect the Releeph DOM to make sure hrefs etc. are relative. Reviewers: wez, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5999
This commit is contained in:
parent
824f934622
commit
4692920751
3 changed files with 3 additions and 3 deletions
|
@ -265,7 +265,7 @@ final class ReleephRequestTransactionalEditor
|
||||||
$body->addTextSection(
|
$body->addTextSection(
|
||||||
pht('RELEEPH BRANCH'),
|
pht('RELEEPH BRANCH'),
|
||||||
$project_and_branch."\n".
|
$project_and_branch."\n".
|
||||||
$releeph_branch->getURI());
|
PhabricatorEnv::getProductionURI($releeph_branch->getURI()));
|
||||||
|
|
||||||
return $body;
|
return $body;
|
||||||
}
|
}
|
||||||
|
|
|
@ -98,7 +98,7 @@ final class ReleephBranch extends ReleephDAO {
|
||||||
rawurlencode($this->getBasename()),
|
rawurlencode($this->getBasename()),
|
||||||
$path
|
$path
|
||||||
);
|
);
|
||||||
return PhabricatorEnv::getProductionURI(implode('/', $components));
|
return implode('/', $components);
|
||||||
}
|
}
|
||||||
|
|
||||||
public function loadReleephProject() {
|
public function loadReleephProject() {
|
||||||
|
|
|
@ -51,7 +51,7 @@ final class ReleephProject extends ReleephDAO
|
||||||
$this->getID(),
|
$this->getID(),
|
||||||
$path
|
$path
|
||||||
);
|
);
|
||||||
return PhabricatorEnv::getProductionURI(implode('/', $components));
|
return implode('/', $components);
|
||||||
}
|
}
|
||||||
|
|
||||||
public function setDetail($key, $value) {
|
public function setDetail($key, $value) {
|
||||||
|
|
Loading…
Reference in a new issue