diff --git a/src/applications/differential/controller/customrenderer/DifferentialRevisionDetailRenderer.php b/src/applications/differential/controller/customrenderer/DifferentialRevisionDetailRenderer.php index 97400668c5..3262549364 100644 --- a/src/applications/differential/controller/customrenderer/DifferentialRevisionDetailRenderer.php +++ b/src/applications/differential/controller/customrenderer/DifferentialRevisionDetailRenderer.php @@ -29,15 +29,4 @@ abstract class DifferentialRevisionDetailRenderer { */ abstract public function generateActionLinks(DifferentialRevision $revision, DifferentialDiff $diff); - - /** - * This function must return an array of properties. These - * properties will be shown below other properties on differential - * revision page. Array keys are used for property names and array - * values are used for the actual property values. These property - * values will be displayed on the page as they are given, so they - * should be properly escaped. - */ - abstract public function generateProperties(DifferentialRevision $revision, - DifferentialDiff $diff); } diff --git a/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php b/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php index 3daae67981..28646f5143 100644 --- a/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php +++ b/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php @@ -163,21 +163,14 @@ class DifferentialRevisionViewController extends DifferentialController { 'differential.revision-custom-detail-renderer'); if ($custom_renderer_class) { - // TODO: Either deprecate generateProperties() or build a better version - // of the action links and deprecate the whole class. Custom fields - // now provide a much more powerful version of generateProperties(). - + // TODO: build a better version of the action links and deprecate the + // whole DifferentialRevisionDetailRenderer class. PhutilSymbolLoader::loadClass($custom_renderer_class); $custom_renderer = newv($custom_renderer_class, array()); - $properties = $custom_renderer->generateProperties($revision, $target); - $revision_detail->setProperties($properties); - $actions = array_merge( $actions, $custom_renderer->generateActionLinks($revision, $target)); - } else { - $revision_detail->setProperties(array()); } $whitespace = $request->getStr( diff --git a/src/applications/differential/view/revisiondetail/DifferentialRevisionDetailView.php b/src/applications/differential/view/revisiondetail/DifferentialRevisionDetailView.php index f0900b72b7..e6d0dc46be 100644 --- a/src/applications/differential/view/revisiondetail/DifferentialRevisionDetailView.php +++ b/src/applications/differential/view/revisiondetail/DifferentialRevisionDetailView.php @@ -19,7 +19,6 @@ final class DifferentialRevisionDetailView extends AphrontView { private $revision; - private $properties; private $actions; private $user; private $auxiliaryFields = array(); @@ -29,11 +28,6 @@ final class DifferentialRevisionDetailView extends AphrontView { return $this; } - public function setProperties(array $properties) { - $this->properties = $properties; - return $this; - } - public function setActions(array $actions) { $this->actions = $actions; return $this; @@ -57,14 +51,6 @@ final class DifferentialRevisionDetailView extends AphrontView { $revision = $this->revision; $rows = array(); - foreach ($this->properties as $key => $field) { - $rows[] = - ''. - ''.phutil_escape_html($key).':'. - ''.$field.''. - ''; - } - foreach ($this->auxiliaryFields as $field) { $value = $field->renderValueForRevisionView(); if ($value !== null) {