revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 09:12:41 +01:00
Code Issues Releases Wiki Activity

Conpherence notifications - fix ordering

Browse source 
Summary: we get participation data ordered, then query conpherences by phid... be sure to resort the conpherences based on participation data. I missed this in testing 'cuz my test data is so trashy, but it is glaringly obvious in production. :/

Test Plan: replied to a very old conpherence and noted it was first in the notification panel

Reviewers: chad, epriestley

Reviewed By: epriestley

CC: Korvin, aran

Maniphest Tasks: T3641

Differential Revision: https://secure.phabricator.com/D6711
This commit is contained in:
Bob Trahan 2013-08-09 13:00:49 -07:00
parent e6f3c24bc3
commit 46c4459dc0
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/conpherence/controller/ConpherenceNotificationPanelController.php
View file

@ -28,6 +28,9 @@ final class ConpherenceNotificationPanelController
if ($conpherences) { if ($conpherences) {
require_celerity_resource('conpherence-notification-css'); require_celerity_resource('conpherence-notification-css');
// re-order the conpherences based on participation data
$conpherences = array_select_keys(
$conpherences, array_keys($participant_data));
$view = new AphrontNullView(); $view = new AphrontNullView();
foreach ($conpherences as $conpherence) { foreach ($conpherences as $conpherence) {
$p_data = $participant_data[$conpherence->getPHID()]; $p_data = $participant_data[$conpherence->getPHID()];