revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00
Code Issues Releases Wiki Activity

Fix a bug for updating diffs

Browse source 
Summary: Hit this issue in D8485. I think reviewedByPHID changes should appear in application transactions.

Test Plan: Would like to deploy this and try updating D8485 again.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: aran, epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D8491
This commit is contained in:
Bob Trahan 2014-03-11 15:36:03 -07:00
parent 0b15624c37
commit 46cf263e9d
1 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/differential/conduit/ConduitAPI_differential_Method.php
View file

@ -80,11 +80,7 @@ abstract class ConduitAPI_differential_Method extends ConduitAPIMethod {
$role = PhabricatorCustomField::ROLE_APPLICATIONTRANSACTIONS; $role = PhabricatorCustomField::ROLE_APPLICATIONTRANSACTIONS;
if (!$field->shouldEnableForRole($role)) { if (!$field->shouldEnableForRole($role)) {
throw new Exception( continue;
pht(
'Request attempts to update field "%s", but that field can not '.
'perform transactional updates.',
$key));
} }
// TODO: This is fairly similar to PhabricatorCustomField's // TODO: This is fairly similar to PhabricatorCustomField's