From 46d1a1d7c12cd13edc20d1dc1ce83d9f79ac07e9 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 24 Apr 2015 14:25:44 -0700
Subject: [PATCH] When the user clicks the notification menu, hide it

Summary: Fixes T7905.

Test Plan: With Quicksand, clicked links and empty space in the notification menu.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7905

Differential Revision: https://secure.phabricator.com/D12541
---
 resources/celerity/map.php                    | 26 +++++++++----------
 .../aphlict/behavior-aphlict-dropdown.js      |  4 ++-
 2 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index a68ffa0b40..f44e62ece8 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -8,7 +8,7 @@
 return array(
   'names' => array(
     'core.pkg.css' => '9a9b59ca',
-    'core.pkg.js' => '6f7446de',
+    'core.pkg.js' => '59d01bb7',
     'darkconsole.pkg.js' => '8ab24e01',
     'differential.pkg.css' => '3500921f',
     'differential.pkg.js' => '890046d3',
@@ -350,7 +350,7 @@ return array(
     'rsrc/image/texture/table_header_hover.png' => '038ec3b9',
     'rsrc/image/texture/table_header_tall.png' => 'd56b434f',
     'rsrc/js/application/aphlict/Aphlict.js' => '30a6303c',
-    'rsrc/js/application/aphlict/behavior-aphlict-dropdown.js' => 'ee37f73a',
+    'rsrc/js/application/aphlict/behavior-aphlict-dropdown.js' => '0323afdd',
     'rsrc/js/application/aphlict/behavior-aphlict-listen.js' => 'b1a59974',
     'rsrc/js/application/aphlict/behavior-aphlict-status.js' => 'ea681761',
     'rsrc/js/application/auth/behavior-persona-login.js' => '9414ff18',
@@ -550,7 +550,7 @@ return array(
     'inline-comment-summary-css' => 'eb5f8e8c',
     'javelin-aphlict' => '30a6303c',
     'javelin-behavior' => '61cbc29a',
-    'javelin-behavior-aphlict-dropdown' => 'ee37f73a',
+    'javelin-behavior-aphlict-dropdown' => '0323afdd',
     'javelin-behavior-aphlict-listen' => 'b1a59974',
     'javelin-behavior-aphlict-status' => 'ea681761',
     'javelin-behavior-aphront-basic-tokenizer' => 'b3a4b884',
@@ -845,6 +845,16 @@ return array(
     '029a133d' => array(
       'aphront-dialog-view-css',
     ),
+    '0323afdd' => array(
+      'javelin-behavior',
+      'javelin-request',
+      'javelin-stratcom',
+      'javelin-vector',
+      'javelin-dom',
+      'javelin-uri',
+      'javelin-behavior-device',
+      'phabricator-title',
+    ),
     '048330fa' => array(
       'javelin-behavior',
       'javelin-typeahead-ondemand-source',
@@ -1940,16 +1950,6 @@ return array(
       'javelin-stratcom',
       'javelin-vector',
     ),
-    'ee37f73a' => array(
-      'javelin-behavior',
-      'javelin-request',
-      'javelin-stratcom',
-      'javelin-vector',
-      'javelin-dom',
-      'javelin-uri',
-      'javelin-behavior-device',
-      'phabricator-title',
-    ),
     'efe49472' => array(
       'javelin-install',
       'javelin-util',
diff --git a/webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js b/webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js
index a3f01bfc30..b1446593f3 100644
--- a/webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js
+++ b/webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js
@@ -138,7 +138,8 @@ JX.behavior('aphlict-dropdown', function(config, statics) {
       }
 
       if (e.getNode('tag:a')) {
-        // User clicked a link, just follow the link.
+        // User clicked a link. Hide the menu, then follow the link.
+        set_visible(null);
         return;
       }
 
@@ -154,6 +155,7 @@ JX.behavior('aphlict-dropdown', function(config, statics) {
       if (href) {
         JX.$U(href).go();
         e.kill();
+        set_visible(null);
       }
     });