Remove some ad-hoc loading of repositories from Releeph

Summary: Ref T3551. Since we now require repositories in order to perform policy checks, things that did loads properly don't need to load this data explicitly.

Test Plan: Edited a product, cut a new branch.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T3551

Differential Revision: https://secure.phabricator.com/D8769

src/applications/releeph/controller/branch/ReleephBranchCreateController.php

@@ -31,11 +31,10 @@ final class ReleephBranchCreateController extends ReleephProductController {
     $symbolic_name = $request->getStr('symbolicName');
 
     if (!$cut_point) {
-      $repository = $product->loadPhabricatorRepository();
+      $repository = $product->getRepository();
       switch ($repository->getVersionControlSystem()) {
         case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
           break;
-
         case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
           $cut_point = $product->getTrunkBranch();
           break;

src/applications/releeph/controller/project/ReleephProductEditController.php

@@ -139,9 +139,7 @@ final class ReleephProductEditController extends ReleephProductController {
         id(new AphrontFormStaticControl())
           ->setLabel(pht('Repository'))
           ->setValue(
-            $product
-              ->loadPhabricatorRepository()
-              ->getName()))
+            $product->getRepository()->getName()))
       ->appendChild(
         id(new AphrontFormStaticControl())
           ->setLabel(pht('Arc Project'))

src/applications/releeph/query/ReleephProjectQuery.php

@@ -7,7 +7,6 @@ final class ReleephProjectQuery
   private $ids;
   private $phids;
 
-  private $needRepositories;
   private $needArcanistProjects;
 
   private $order    = 'order-id';