revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 05:12:41 +01:00
Code Issues Releases Wiki Activity

Remove some ad-hoc loading of repositories from Releeph

Browse source 
Summary: Ref T3551. Since we now require repositories in order to perform policy checks, things that did loads properly don't need to load this data explicitly.

Test Plan: Edited a product, cut a new branch.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T3551

Differential Revision: https://secure.phabricator.com/D8769
This commit is contained in:
epriestley 2014-04-14 12:08:04 -07:00
parent f4c8a34abe
commit 47245b1b59
3 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/releeph/controller/branch/ReleephBranchCreateController.php
View file

@ -31,11 +31,10 @@ final class ReleephBranchCreateController extends ReleephProductController {
$symbolic_name = $request->getStr('symbolicName'); $symbolic_name = $request->getStr('symbolicName');
if (!$cut_point) { if (!$cut_point) {
$repository = $product->loadPhabricatorRepository(); $repository = $product->getRepository();
switch ($repository->getVersionControlSystem()) { switch ($repository->getVersionControlSystem()) {
case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN: case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
break; break;
case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT: case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
$cut_point = $product->getTrunkBranch(); $cut_point = $product->getTrunkBranch();
break; break;

4
src/applications/releeph/controller/project/ReleephProductEditController.php
View file

@ -139,9 +139,7 @@ final class ReleephProductEditController extends ReleephProductController {
id(new AphrontFormStaticControl()) id(new AphrontFormStaticControl())
->setLabel(pht('Repository')) ->setLabel(pht('Repository'))
->setValue( ->setValue(
$product $product->getRepository()->getName()))
->loadPhabricatorRepository()
->getName()))
->appendChild( ->appendChild(
id(new AphrontFormStaticControl()) id(new AphrontFormStaticControl())
->setLabel(pht('Arc Project')) ->setLabel(pht('Arc Project'))

1
src/applications/releeph/query/ReleephProjectQuery.php
View file

@ -7,7 +7,6 @@ final class ReleephProjectQuery
private $ids; private $ids;
private $phids; private $phids;
private $needRepositories;
private $needArcanistProjects; private $needArcanistProjects;
private $order = 'order-id'; private $order = 'order-id';