revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exception in PhabricatorStandardCustomFieldLink.php

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15807

Test Plan: Unknown. Given that `$value` is later used to construct a `phutil_tag` I assume that it should be a string and not a scalar.

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15807

Differential Revision: https://we.phorge.it/D25610
This commit is contained in:
Andre Klapper 2024-05-01 17:39:20 +02:00
parent fbe07fbeef
commit 488960ae7a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php
View file

@ -21,7 +21,7 @@ final class PhabricatorStandardCustomFieldLink
public function renderPropertyViewValue(array $handles) { public function renderPropertyViewValue(array $handles) {
$value = $this->getFieldValue(); $value = $this->getFieldValue();
if (!strlen($value)) { if (!phutil_nonempty_string($value)) {
return null; return null;
} }