Excluded authored commits from "Ready to Audit"; handle unreachable commits better

Summary:
Ref T10978. I'm inching toward cleaning up our audit state. Two issues are:

  - Authored commits show up in "Ready to Audit", but should not.
  - Unreachable commits (like that stacked of unsquashed stuff) show up too, but we don't really care about them.

Kick authored stuff out of the "Ready to Audit" bucket and hide unreachable commits by default, with constraints for filtering. Also give them a closed/disabled/strikethru style.

Test Plan:
  - Viewed audit buckets.
  - Searched for reachable/unreachable commits.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10978

Differential Revision: https://secure.phabricator.com/D17279

src/applications/audit/query/PhabricatorCommitSearchEngine.php

@@ -49,6 +49,10 @@ final class PhabricatorCommitSearchEngine
       $query->withPackagePHIDs($map['packagePHIDs']);
     }
 
+    if ($map['unreachable'] !== null) {
+      $query->withUnreachable($map['unreachable']);
+    }
+
     return $query;
   }
 
@@ -88,6 +92,17 @@ final class PhabricatorCommitSearchEngine
         ->setConduitKey('packages')
         ->setAliases(array('package', 'packages', 'packagePHID'))
         ->setDatasource(new PhabricatorOwnersPackageDatasource()),
+      id(new PhabricatorSearchThreeStateField())
+        ->setLabel(pht('Unreachable'))
+        ->setKey('unreachable')
+        ->setOptions(
+          pht('(Show All)'),
+          pht('Show Only Unreachable Commits'),
+          pht('Hide Unreachable Commits'))
+        ->setDescription(
+          pht(
+            'Find or exclude unreachable commits which are not ancestors of '.
+            'any branch, tag, or ref.')),
     );
   }
 
@@ -126,7 +141,8 @@ final class PhabricatorCommitSearchEngine
         $query
           ->setParameter('responsiblePHIDs', array($viewer_phid))
           ->setParameter('statuses', $open)
-          ->setParameter('bucket', $bucket_key);
+          ->setParameter('bucket', $bucket_key)
+          ->setParameter('unreachable', false);
         return $query;
       case 'authored':
         $query

src/applications/audit/view/PhabricatorAuditListView.php

@@ -140,6 +140,7 @@ final class PhabricatorAuditListView extends AphrontView {
         ->setObjectName($commit_name)
         ->setHeader($commit_desc)
         ->setHref($commit_link)
+        ->setDisabled($commit->isUnreachable())
         ->addByline(pht('Author: %s', $author_name))
         ->addIcon('none', $committed);
 

src/applications/diffusion/query/DiffusionCommitQuery.php

@@ -14,6 +14,7 @@ final class DiffusionCommitQuery
   private $responsiblePHIDs;
   private $statuses;
   private $packagePHIDs;
+  private $unreachable;
 
   private $needAuditRequests;
   private $auditIDs;
@@ -130,6 +131,11 @@ final class DiffusionCommitQuery
     return $this;
   }
 
+  public function withUnreachable($unreachable) {
+    $this->unreachable = $unreachable;
+    return $this;
+  }
+
   public function withStatuses(array $statuses) {
     $this->statuses = $statuses;
     return $this;
@@ -503,6 +509,21 @@ final class DiffusionCommitQuery
         $this->packagePHIDs);
     }
 
+    if ($this->unreachable !== null) {
+      if ($this->unreachable) {
+        $where[] = qsprintf(
+          $conn,
+          '(commit.importStatus & %d) = %d',
+          PhabricatorRepositoryCommit::IMPORTED_UNREACHABLE,
+          PhabricatorRepositoryCommit::IMPORTED_UNREACHABLE);
+      } else {
+        $where[] = qsprintf(
+          $conn,
+          '(commit.importStatus & %d) = 0',
+          PhabricatorRepositoryCommit::IMPORTED_UNREACHABLE);
+      }
+    }
+
     return $where;
   }
 

src/applications/diffusion/query/DiffusionCommitRequiredActionResultBucket.php

@@ -128,6 +128,10 @@ final class DiffusionCommitRequiredActionResultBucket
     $should_audit = array_fuse($should_audit);
 
     foreach ($objects as $key => $object) {
+      if (isset($phids[$object->getAuthorPHID()])) {
+        continue;
+      }
+
       if (!$this->hasAuditorsWithStatus($object, $phids, $should_audit)) {
         continue;
       }