revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Allow updating diff with results for new unit tests

Browse source 
Summary:
When using postponed unittests to make 'arc diff' faster, there
are some situations where it is difficult to know exactly how
many unittests will be run.  This is the case for many of our
C++ unittests, which we can't really know until we compile the
tests (which is slow, and probably isn't reasonable to be done
before posting the diff).  I suppose we could make sure we
explicitly which tests a C++ unittest will run in some way, but
this would require a lot of change to our backend test infra.
Also, it seems that this is a pretty general issue of not knowing
how many unittests will be run until they actually run.

This diff adds an optional "create" parameter to updateunitresults
which wil create a new unit tests result rather than updating an
existing one.  I am not sure if this really fits here or should
be its own method, but there is a lot of code re-use between them
so I consolidated.

Test Plan: updated a diff with a new unit test result

Reviewers: epriestley, jungejason

Reviewed By: epriestley

CC: aran, epriestley, andrewjcg, tuomaspelkonen

Differential Revision: https://secure.phabricator.com/D1352
This commit is contained in:
Andrew Gallagher 2012-01-03 19:05:55 -08:00
parent 84ea5c53e4
commit 48f53ba095
2 changed files with 13 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/applications/conduit/method/differential/updateunitresults/ConduitAPI_differential_updateunitresults_Method.php
View file

@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -74,13 +74,11 @@ extends ConduitAPIMethod {
$postponed_count = 0;
$unit_status = null;
// If the test result already exists, then update it with
// the new info.
foreach ($unit_results as &$unit_result) {
// Update the results for the test that has the same path.
if (($unit_result['name'] === $file ||
$unit_result['name'] === $diff->getSourcePath().$file) &&
$unit_result['result'] ===
DifferentialUnitTestResult::RESULT_POSTPONED) {
$unit_result['name'] = $name;
if ($unit_result['name'] === $name) {
$unit_result['file'] = $file;
$unit_result['result'] = $result;
$unit_result['userdata'] = $message;
$unit_status = $result;
@ -89,10 +87,15 @@ extends ConduitAPIMethod {
}
unset($unit_result);
// If the test result doesn't exist, just add it.
if (!$unit_status) {
phlog("Could not update test results: {$diff_id} {$file} {$name}".
" {$result} {$message}");
return;
$unit_result = array();
$unit_result['file'] = $file;
$unit_result['name'] = $name;
$unit_result['result'] = $result;
$unit_result['userdata'] = $message;
$unit_status = $result;
$unit_results[] = $unit_result;
}
$diff_property->setData($unit_results);

1
src/applications/conduit/method/differential/updateunitresults/__init__.php
View file

@ -13,7 +13,6 @@ phutil_require_module('phabricator', 'applications/differential/constants/unitte
phutil_require_module('phabricator', 'applications/differential/storage/diff');
phutil_require_module('phabricator', 'applications/differential/storage/diffproperty');
phutil_require_module('phutil', 'error');
phutil_require_module('phutil', 'utils');