revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-04-09 19:08:40 +02:00
Code Issues Releases Wiki Activity

Fix warnings for undefined $next_step and $verb

Browse source 
Summary: Revisions don't necessarily have a backing repository, as in "--raw".

Test Plan: Looked at a "--raw" revision in accepted and closed states.

Reviewers: nh, btrahan

Reviewed By: nh

CC: aran

Differential Revision: https://secure.phabricator.com/D2444
This commit is contained in:
epriestley 2012-05-10 11:43:35 -07:00
parent 5a1d89227b
commit 4921f3f13b
1 changed files with 16 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/applications/differential/field/specification/revisionstatus/DifferentialRevisionStatusFieldSpecification.php
View file

@ -40,6 +40,7 @@ final class DifferentialRevisionStatusFieldSpecification
} }
if ($status == ArcanistDifferentialRevisionStatus::ACCEPTED) { if ($status == ArcanistDifferentialRevisionStatus::ACCEPTED) {
$next_step = null;
if ($local_vcs == $backing_vcs) { if ($local_vcs == $backing_vcs) {
switch ($local_vcs) { switch ($local_vcs) {
case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL: case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
@ -58,21 +59,24 @@ final class DifferentialRevisionStatusFieldSpecification
if ($next_step) { if ($next_step) {
$info = ' · Next step: '.$next_step; $info = ' · Next step: '.$next_step;
} }
} else if ($status == ArcanistDifferentialRevisionStatus::CLOSED) { } else if ($status == ArcanistDifferentialRevisionStatus::CLOSED) {
$committed = $revision->getDateCommitted(); $committed = $revision->getDateCommitted();
switch ($backing_vcs) { if ($committed) {
case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL: $verb = null;
case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT: switch ($backing_vcs) {
$verb = 'Pushed'; case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
break; case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN: $verb = 'Pushed';
$verb = 'Committed'; break;
break; case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
$verb = 'Committed';
break;
}
if ($verb) {
$when = phabricator_datetime($committed, $this->getUser());
$info = " ({$verb} {$when})";
}
} }
$when = phabricator_datetime($committed, $this->getUser());
$info = " ({$verb} {$when})";
} }
$status = $status =