revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-20 05:42:40 +01:00
Code Issues Releases Wiki Activity

Remove documentation about obsolete Differential event listeners

Browse source 
Summary:
Fixes T5069. T2222 mostly-intentionally stopped emitting these.

My sense is that users generally find event listeners (or, really, writing PHP at all) much less preferable to things like Herald rules or HTTP hooks. This is generally good, since those things are way easier to maintain, so I plan to continue moving away from events in cases where we have reasonable alternatives.

We also generally have more and better alternatives now than when these were written.

Test Plan: `grep`

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5069

Differential Revision: https://secure.phabricator.com/D9151
This commit is contained in:
epriestley 2014-05-16 08:47:00 -07:00
parent 45f4431a84
commit 4925dd7e6e
2 changed files with 0 additions and 41 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
src/docs/user/userguide/events.diviner
View file

@ -182,16 +182,6 @@ edit. Data available on this event:
This is similar to the previous event (will edit task) but occurs after the This is similar to the previous event (will edit task) but occurs after the
edit completes. edit completes.
== Differential: Will Send Mail ==
The constant for this event is
`PhabricatorEventType::TYPE_DIFFERENTIAL_WILLSENDMAIL`
This event is dispatched before Differential sends an email, and allows you to
edit the message that will be sent. Data available on this event:
- ##mail## The @{class:PhabricatorMetaMTAMail} being edited.
== Differential: Will Mark Generated == == Differential: Will Mark Generated ==
The constant for this event is The constant for this event is
@ -204,34 +194,6 @@ doesn't need to be reviewed) or not. Data available on this event:
- ##is_generated## Boolean indicating if this file should be treated as - ##is_generated## Boolean indicating if this file should be treated as
generated. generated.
== Differential: Will Edit Revision ==
The constant for this event is
`PhabricatorEventType::TYPE_DIFFERENTIAL_WILLEDITREVISION`.
This event is dispatched before a revision is edited, and allows you to
respond to or alter the edit. Data available on this event:
- ##revision## The @{class:DifferentialRevision} being edited.
- ##new## A boolean indicating if this revision is being created.
This is similar to the next event (did edit revision) but occurs before the edit
begins.
== Differential: Did Edit Revision ==
The constant for this event is
`PhabricatorEventType::TYPE_DIFFERENTIAL_DIDEDITREVISION`.
This event is dispatched after a revision is edited, and allows you to
react to the edit. Data available on this event:
- ##revision## The @{class:DifferentialRevision} being edited.
- ##new## A boolean indicating if this revision is being created.
This is similar to the previous event (will edit revision) but occurs after the
edit completes.
== Diffusion: Did Discover Commit == == Diffusion: Did Discover Commit ==
The constant for this event is The constant for this event is

3
src/infrastructure/events/constant/PhabricatorEventType.php
View file

@ -13,10 +13,7 @@ final class PhabricatorEventType extends PhutilEventType {
const TYPE_MANIPHEST_WILLEDITTASK = 'maniphest.willEditTask'; const TYPE_MANIPHEST_WILLEDITTASK = 'maniphest.willEditTask';
const TYPE_MANIPHEST_DIDEDITTASK = 'maniphest.didEditTask'; const TYPE_MANIPHEST_DIDEDITTASK = 'maniphest.didEditTask';
const TYPE_DIFFERENTIAL_WILLSENDMAIL = 'differential.willSendMail';
const TYPE_DIFFERENTIAL_WILLMARKGENERATED = 'differential.willMarkGenerated'; const TYPE_DIFFERENTIAL_WILLMARKGENERATED = 'differential.willMarkGenerated';
const TYPE_DIFFERENTIAL_WILLEDITREVISION = 'differential.willEditRevision';
const TYPE_DIFFERENTIAL_DIDEDITREVISION = 'differential.didEditRevision';
const TYPE_DIFFUSION_DIDDISCOVERCOMMIT = 'diffusion.didDiscoverCommit'; const TYPE_DIFFUSION_DIDDISCOVERCOMMIT = 'diffusion.didDiscoverCommit';
const TYPE_DIFFUSION_LOOKUPUSER = 'diffusion.lookupUser'; const TYPE_DIFFUSION_LOOKUPUSER = 'diffusion.lookupUser';