From 4936be0868bd14a4f7421d07d2cb95b9088a17c5 Mon Sep 17 00:00:00 2001 From: epriestley Date: Sun, 5 Jun 2016 13:39:39 -0700 Subject: [PATCH] Fix exception when trying to save global setting mail tags Summary: Ref T11098. Template preferences don't have a user, but this codepath didn't get fully updated to account for that. Test Plan: Saved mail tags in global prefernces. Reviewers: avivey, chad Reviewed By: chad Maniphest Tasks: T11098 Differential Revision: https://secure.phabricator.com/D16050 --- .../settings/panel/PhabricatorEmailPreferencesSettingsPanel.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/settings/panel/PhabricatorEmailPreferencesSettingsPanel.php b/src/applications/settings/panel/PhabricatorEmailPreferencesSettingsPanel.php index ee1bac1b1e..0c775c5a4d 100644 --- a/src/applications/settings/panel/PhabricatorEmailPreferencesSettingsPanel.php +++ b/src/applications/settings/panel/PhabricatorEmailPreferencesSettingsPanel.php @@ -160,7 +160,7 @@ final class PhabricatorEmailPreferencesSettingsPanel return $editors; } - private function getAllTags(PhabricatorUser $user) { + private function getAllTags(PhabricatorUser $user = null) { $tags = array(); foreach ($this->getAllEditorsWithTags($user) as $editor) { $tags += $editor->getMailTagsMap();