From 495e1384dd5c3d1baf0e1a50b95ee4320c50086f Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 18 Jan 2016 06:57:16 -0800 Subject: [PATCH] Fix project queries in Ponder Summary: Fixes T10167. We were dropping infrastructure joins. Test Plan: Queried for questions by project. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10167 Differential Revision: https://secure.phabricator.com/D15043 --- src/applications/ponder/query/PonderQuestionQuery.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/applications/ponder/query/PonderQuestionQuery.php b/src/applications/ponder/query/PonderQuestionQuery.php index 480f2c3296..9762f925f5 100644 --- a/src/applications/ponder/query/PonderQuestionQuery.php +++ b/src/applications/ponder/query/PonderQuestionQuery.php @@ -129,13 +129,13 @@ final class PonderQuestionQuery return $questions; } - protected function buildJoinClauseParts(AphrontDatabaseConnection $conn_r) { - $joins = array(); + protected function buildJoinClauseParts(AphrontDatabaseConnection $conn) { + $joins = parent::buildJoinClauseParts($conn); if ($this->answererPHIDs) { $answer_table = new PonderAnswer(); $joins[] = qsprintf( - $conn_r, + $conn, 'JOIN %T a ON a.questionID = q.id AND a.authorPHID IN (%Ls)', $answer_table->getTableName(), $this->answererPHIDs);