From 49a44a0b1f767e340533474d3cebc40705982e16 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 26 Jan 2016 07:27:41 -0800 Subject: [PATCH] Make project menus unconditionally configurable Summary: Fixes T10213. I think the "Edit" item was originally conditional (or maybe I just forgot to add that part), but that got dropped when we swapped how it worked. This is all stable now anyway and can be available without needing prototypes enabled. Test Plan: Edited a project menu. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10213 Differential Revision: https://secure.phabricator.com/D15117 --- .../project/engine/PhabricatorProjectProfilePanelEngine.php | 4 ++++ .../search/engine/PhabricatorProfilePanelEngine.php | 4 +--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/applications/project/engine/PhabricatorProjectProfilePanelEngine.php b/src/applications/project/engine/PhabricatorProjectProfilePanelEngine.php index ce66b9b22b..612022d380 100644 --- a/src/applications/project/engine/PhabricatorProjectProfilePanelEngine.php +++ b/src/applications/project/engine/PhabricatorProjectProfilePanelEngine.php @@ -3,6 +3,10 @@ final class PhabricatorProjectProfilePanelEngine extends PhabricatorProfilePanelEngine { + protected function isPanelEngineConfigurable() { + return true; + } + protected function getPanelURI($path) { $project = $this->getProfileObject(); $id = $project->getID(); diff --git a/src/applications/search/engine/PhabricatorProfilePanelEngine.php b/src/applications/search/engine/PhabricatorProfilePanelEngine.php index 6500676bd1..0910c8f74b 100644 --- a/src/applications/search/engine/PhabricatorProfilePanelEngine.php +++ b/src/applications/search/engine/PhabricatorProfilePanelEngine.php @@ -49,9 +49,7 @@ abstract class PhabricatorProfilePanelEngine extends Phobject { abstract protected function getPanelURI($path); - protected function isPanelEngineConfigurable() { - return PhabricatorEnv::getEnvConfig('phabricator.show-prototypes'); - } + abstract protected function isPanelEngineConfigurable(); public function buildResponse() { $controller = $this->getController();