revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

Fix download button to work on firefox

Browse source 
Summary: need to setTimeout on the removal from the DOM so these browsers don't freak out

Test Plan: downloaded images on firefox and safari

Reviewers: vrana, epriestley

Reviewed By: vrana

CC: aran, Korvin

Maniphest Tasks: T1896

Differential Revision: https://secure.phabricator.com/D3799
This commit is contained in:
Bob Trahan 2012-10-23 11:52:59 -07:00
parent e0cc277d5f
commit 49a7f9e7d7
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
webroot/rsrc/js/application/core/behavior-lightbox-attachments.js
View file

@ -154,7 +154,12 @@ JX.behavior('lightbox-attachments', function (config) {
'click', 'click',
null, null,
function (e) { function (e) {
e.prevent(); closeLightBox(e); form.submit(); e.prevent();
form.submit();
// Firefox and probably IE need this trick to work.
// Removing a form from the DOM while its submitting is
// tricky business.
setTimeout(JX.bind(null, closeLightBox, e), 0);
} }
); );
var downloadSpan = JX.$N('span', var downloadSpan = JX.$N('span',