revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 05:12:41 +01:00
Code Issues Releases Wiki Activity

Allow a limit to be set on the number of results in a query panel

Browse source 
Summary: This allows a maximum number of items to be set in a query panel.  Mostly useful when you have a query panel on the feed search and you don't want 4 billion results cluttering your dashboard.

Test Plan: Created a query panel with a maximum and it worked.  Left it blank and got the default results.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T4980

Differential Revision: https://secure.phabricator.com/D9235
This commit is contained in:
James Rhodes 2014-05-21 10:09:51 -07:00 committed by epriestley
parent eba11238b9
commit 49c15a6d95
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeQuery.php
View file

@ -27,6 +27,11 @@ final class PhabricatorDashboardPanelTypeQuery
'name' => pht('ApplicationSearch Key'), 'name' => pht('ApplicationSearch Key'),
'type' => 'text', 'type' => 'text',
), ),
'limit' => array(
'name' => pht('Maximum Number of Items'),
'caption' => pht('Leave this blank for the default number of items'),
'type' => 'text',
),
); );
} }
@ -68,6 +73,14 @@ final class PhabricatorDashboardPanelTypeQuery
$query = $engine->buildQueryFromSavedQuery($saved); $query = $engine->buildQueryFromSavedQuery($saved);
$pager = $engine->newPagerForSavedQuery($saved); $pager = $engine->newPagerForSavedQuery($saved);
if ($panel->getProperty('limit')) {
$limit = (int)$panel->getProperty('limit');
if ($pager->getPageSize() !== 0xFFFF) {
$pager->setPageSize($limit);
}
}
$results = $engine->executeQuery($query, $pager); $results = $engine->executeQuery($query, $pager);
return $engine->renderResults($results, $saved); return $engine->renderResults($results, $saved);