Enrich "draft", "summary", and "testPlan" transactions from Differential in "transaction.search"

Summary:
See PHI1232, which describes a reasonable use case for wanting information about the "draft" ("Hold as Draft / Do Not Auto-Promote") flag.

Also, flesh out "testPlan" and "summary". It's possible these "blob of remarkup" fields might have metadata some day (e.g., a rendered version or a list of PHIDs or something), but we could add more keys, and we already have some other transactions which work like this.

Test Plan: Used "transaction.search" to fetch these transaction types, saw type information and metadata.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20507

src/applications/differential/xaction/DifferentialRevisionHoldDraftTransaction.php

@@ -55,4 +55,15 @@ final class DifferentialRevisionHoldDraftTransaction
     }
   }
 
+  public function getTransactionTypeForConduit($xaction) {
+    return 'draft';
+  }
+
+  public function getFieldValuesForConduit($xaction, $data) {
+    return array(
+      'old' => $xaction->getOldValue(),
+      'new' => $xaction->getNewValue(),
+    );
+  }
+
 }

src/applications/differential/xaction/DifferentialRevisionSummaryTransaction.php

@@ -61,4 +61,15 @@ final class DifferentialRevisionSummaryTransaction
       pht('Summary'));
   }
 
+  public function getTransactionTypeForConduit($xaction) {
+    return 'summary';
+  }
+
+  public function getFieldValuesForConduit($xaction, $data) {
+    return array(
+      'old' => $xaction->getOldValue(),
+      'new' => $xaction->getNewValue(),
+    );
+  }
+
 }

src/applications/differential/xaction/DifferentialRevisionTestPlanTransaction.php

@@ -75,4 +75,15 @@ final class DifferentialRevisionTestPlanTransaction
     return $errors;
   }
 
+  public function getTransactionTypeForConduit($xaction) {
+    return 'testPlan';
+  }
+
+  public function getFieldValuesForConduit($xaction, $data) {
+    return array(
+      'old' => $xaction->getOldValue(),
+      'new' => $xaction->getNewValue(),
+    );
+  }
+
 }

src/applications/differential/xaction/DifferentialRevisionTitleTransaction.php

@@ -59,10 +59,10 @@ final class DifferentialRevisionTitleTransaction
     return 'title';
   }
 
-  public function getFieldValuesForConduit($object, $data) {
+  public function getFieldValuesForConduit($xaction, $data) {
     return array(
-      'old' => $object->getOldValue(),
-      'new' => $object->getNewValue(),
+      'old' => $xaction->getOldValue(),
+      'new' => $xaction->getNewValue(),
     );
   }
 

src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php

@@ -225,12 +225,12 @@ final class DifferentialRevisionUpdateTransaction
     return 'update';
   }
 
-  public function getFieldValuesForConduit($object, $data) {
-    $commit_phids = $object->getMetadataValue('commitPHIDs', array());
+  public function getFieldValuesForConduit($xaction, $data) {
+    $commit_phids = $xaction->getMetadataValue('commitPHIDs', array());
 
     return array(
-      'old' => $object->getOldValue(),
-      'new' => $object->getNewValue(),
+      'old' => $xaction->getOldValue(),
+      'new' => $xaction->getNewValue(),
       'commitPHIDs' => $commit_phids,
     );
   }