From 4a6229ee693bbd8b37e25d367b84ee8b0e7268d3 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 5 Dec 2016 09:46:39 -0800 Subject: [PATCH] Remove some no-op "canUninstall()" Application methods Summary: The default behavior of these methods is to return `true`, so these overrides have no effect. Test Plan: `grep`; poked around. Reviewers: chad Reviewed By: chad Subscribers: hach-que Differential Revision: https://secure.phabricator.com/D16985 --- .../badges/application/PhabricatorBadgesApplication.php | 4 ---- .../nuance/application/PhabricatorNuanceApplication.php | 4 ---- .../phragment/application/PhabricatorPhragmentApplication.php | 4 ---- 3 files changed, 12 deletions(-) diff --git a/src/applications/badges/application/PhabricatorBadgesApplication.php b/src/applications/badges/application/PhabricatorBadgesApplication.php index 5423609fda..ce52eff99a 100644 --- a/src/applications/badges/application/PhabricatorBadgesApplication.php +++ b/src/applications/badges/application/PhabricatorBadgesApplication.php @@ -26,10 +26,6 @@ final class PhabricatorBadgesApplication extends PhabricatorApplication { return self::GROUP_UTILITIES; } - public function canUninstall() { - return true; - } - public function isPrototype() { return true; } diff --git a/src/applications/nuance/application/PhabricatorNuanceApplication.php b/src/applications/nuance/application/PhabricatorNuanceApplication.php index dede1175ab..cf18bc389d 100644 --- a/src/applications/nuance/application/PhabricatorNuanceApplication.php +++ b/src/applications/nuance/application/PhabricatorNuanceApplication.php @@ -23,10 +23,6 @@ final class PhabricatorNuanceApplication extends PhabricatorApplication { return false; } - public function canUninstall() { - return true; - } - public function getBaseURI() { return '/nuance/'; } diff --git a/src/applications/phragment/application/PhabricatorPhragmentApplication.php b/src/applications/phragment/application/PhabricatorPhragmentApplication.php index 0ca2e5c1e2..164e0293fd 100644 --- a/src/applications/phragment/application/PhabricatorPhragmentApplication.php +++ b/src/applications/phragment/application/PhabricatorPhragmentApplication.php @@ -30,10 +30,6 @@ final class PhabricatorPhragmentApplication extends PhabricatorApplication { return true; } - public function canUninstall() { - return true; - } - public function getRoutes() { return array( '/phragment/' => array(