revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00
Code Issues Releases Wiki Activity

Don't log lost connection retries

Browse source 
Summary:
In D1460, we added initial-connection retries and additional logging in response to network/router instability at Facebook.

One of these logs occurs normally, though, when daemons get disconnected by 'wait_timeout' settings. This is noisy for a lot of installs and a few people have asked me about it.

I assume the situation has cleared up a bit at Facebook, so we can remove the "business as usual" log and keep error logs quieter for general installs?

Test Plan: Weathered the support storm.

Reviewers: nh, vrana

Reviewed By: nh

CC: Makinde, aran

Differential Revision: https://secure.phabricator.com/D2736
This commit is contained in:
epriestley 2012-06-13 14:42:34 -07:00
parent c868ec7d11
commit 4ac1fa1432
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/storage/connection/mysql/AphrontMySQLDatabaseConnectionBase.php
View file

@ -199,10 +199,6 @@ abstract class AphrontMySQLDatabaseConnectionBase
if (!$retries) { if (!$retries) {
throw $ex; throw $ex;
} }
$class = get_class($ex);
$message = $ex->getMessage();
phlog("Retrying ({$retries}) after {$class}: {$message}");
} }
} }
} }