revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 13:22:42 +01:00
Code Issues Releases Wiki Activity

Don't store IP addresses in content sources

Browse source 
Summary:
We don't use these for anything, we're inconsistent about recording them, and there's some mild interaction with privacy concerns and data retention. Every other log we store any kind of information in can be given a custom retention policy after recent GC changes.

If we did put this back eventually it would probably be better to store a session identifier anyway, since that's more granular and more detailed.

You can fetch this info out of access logs anyway, too.

Test Plan: Left a couple of comments.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D14315
This commit is contained in:
epriestley 2015-10-21 12:37:37 -07:00
parent 5b619862cb
commit 4afeebe834
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/metamta/contentsource/PhabricatorContentSource.php
View file

@ -54,9 +54,7 @@ final class PhabricatorContentSource extends Phobject {
public static function newFromRequest(AphrontRequest $request) { public static function newFromRequest(AphrontRequest $request) {
return self::newForSource( return self::newForSource(
self::SOURCE_WEB, self::SOURCE_WEB,
array( array());
'ip' => $request->getRemoteAddr(),
));
} }
public static function newFromConduitRequest(ConduitAPIRequest $request) { public static function newFromConduitRequest(ConduitAPIRequest $request) {