mirror of
https://we.phorge.it/source/phorge.git
synced 2025-01-03 11:21:01 +01:00
Fix application order, curing "Log Out" of wanderlust
Summary: Fixes T3894. The "Log Out" icon has moved away from its rightmost position in the menubar. In rP2e5ac12, I added a "Policy" application. This was the root cause. The reordering logic (below) is slightly wrong. The `array_select_keys()` call is actually using the //strings// (like "Admnistration") to select the groups, not the correct constants (like "admin"). Use the constants instead and get the expected group ordering. Test Plan: Loaded page, "Log Out" is in the rightmost position. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T3894 Differential Revision: https://secure.phabricator.com/D7177
This commit is contained in:
parent
b592630d72
commit
4b39cc321b
1 changed files with 4 additions and 1 deletions
|
@ -270,7 +270,10 @@ abstract class PhabricatorApplication {
|
|||
// ensures their event handlers register in application order.
|
||||
$apps = msort($apps, 'getApplicationOrder');
|
||||
$apps = mgroup($apps, 'getApplicationGroup');
|
||||
$apps = array_select_keys($apps, self::getApplicationGroups()) + $apps;
|
||||
|
||||
$group_order = array_keys(self::getApplicationGroups());
|
||||
$apps = array_select_keys($apps, $group_order) + $apps;
|
||||
|
||||
$apps = array_mergev($apps);
|
||||
|
||||
$applications = $apps;
|
||||
|
|
Loading…
Reference in a new issue