1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-10 23:01:04 +01:00

Add "you can only enter one value" UI limits to Herald "set status" and "set priority" actions

Summary:
Ref T13048. Fixes T11112. I mostly fixed this before in D18887, but missed that these other actions are also affected. T11112 had a more complete list of missing limits.

(It's possible there are some others somewhere, but this is everything we know about, I think.)

Test Plan: Created rules using these actions, typed stuff into the box, was only able to enter one value.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13048, T11112

Differential Revision: https://secure.phabricator.com/D18943
This commit is contained in:
epriestley 2018-01-26 09:39:00 -08:00
parent 7e7720803c
commit 4b5a78e343
2 changed files with 4 additions and 2 deletions

View file

@ -61,7 +61,8 @@ final class ManiphestTaskPriorityHeraldAction
}
protected function getDatasource() {
return new ManiphestTaskPriorityDatasource();
return id(new ManiphestTaskPriorityDatasource())
->setLimit(1);
}
protected function getDatasourceValueMap() {

View file

@ -58,7 +58,8 @@ final class ManiphestTaskStatusHeraldAction
}
protected function getDatasource() {
return new ManiphestTaskStatusDatasource();
return id(new ManiphestTaskStatusDatasource())
->setLimit(1);
}
protected function getDatasourceValueMap() {