revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-29 08:50:58 +01:00
Code Issues Releases Wiki Activity

Make an old migration a little more robust

Browse source 
Summary: See https://github.com/facebook/phabricator/pull/507

Test Plan: This is hard to test since the migration no longer runs against HEAD, but pull 507 strongly implies this is the correct fix.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D8837
This commit is contained in:
epriestley 2014-04-23 14:22:02 -07:00
parent 67f015a76c
commit 4bbd2d5203
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
resources/sql/patches/20131004.dxreviewers.php
View file

@ -29,6 +29,13 @@ foreach (new LiskMigrationIterator($table) as $revision) {
->setActor(PhabricatorUser::getOmnipotentUser()); ->setActor(PhabricatorUser::getOmnipotentUser());
foreach ($reviewer_phids as $dst) { foreach ($reviewer_phids as $dst) {
if (phid_get_type($dst) == PhabricatorPHIDConstants::PHID_TYPE_UNKNOWN) {
// At least one old install ran into some issues here. Skip the row if we
// can't figure out what the destination PHID is. See here:
// https://github.com/facebook/phabricator/pull/507
continue;
}
$editor->addEdge( $editor->addEdge(
$revision_phid, $revision_phid,
PhabricatorEdgeConfig::TYPE_DREV_HAS_REVIEWER, PhabricatorEdgeConfig::TYPE_DREV_HAS_REVIEWER,