Fix IE7 and IE8 issues.

Summary: Resolves submit issues in IE7, scrollbars in IE7 and homepage layout issues in IE7 and IE8.

Test Plan: used IE7 and IE8. Logged in, bounced around. Checked Chrome as well.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2469, T2470

Differential Revision: https://secure.phabricator.com/D4853

src/__celerity_resource_map__.php

@@ -2614,7 +2614,7 @@ celerity_register_resource_map(array(
   ),
   'phabricator-core-css' =>
   array(
-    'uri' => '/res/03c97d00/rsrc/css/core/core.css',
+    'uri' => '/res/27afb689/rsrc/css/core/core.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -3423,7 +3423,7 @@ celerity_register_resource_map(array(
 ), array(
   'packages' =>
   array(
-    '23503cb9' =>
+    '77c4590d' =>
     array(
       'name' => 'core.pkg.css',
       'symbols' =>
@@ -3467,7 +3467,7 @@ celerity_register_resource_map(array(
         36 => 'phabricator-object-item-list-view-css',
         37 => 'global-drag-and-drop-css',
       ),
-      'uri' => '/res/pkg/23503cb9/core.pkg.css',
+      'uri' => '/res/pkg/77c4590d/core.pkg.css',
       'type' => 'css',
     ),
     '58743fec' =>
@@ -3657,19 +3657,19 @@ celerity_register_resource_map(array(
   'reverse' =>
   array(
     'aphront-attached-file-view-css' => 'e30a3fa8',
-    'aphront-crumbs-view-css' => '23503cb9',
-    'aphront-dialog-view-css' => '23503cb9',
-    'aphront-error-view-css' => '23503cb9',
-    'aphront-form-view-css' => '23503cb9',
+    'aphront-crumbs-view-css' => '77c4590d',
+    'aphront-dialog-view-css' => '77c4590d',
+    'aphront-error-view-css' => '77c4590d',
+    'aphront-form-view-css' => '77c4590d',
     'aphront-headsup-action-list-view-css' => 'ec01d039',
-    'aphront-headsup-view-css' => '23503cb9',
-    'aphront-list-filter-view-css' => '23503cb9',
-    'aphront-pager-view-css' => '23503cb9',
-    'aphront-panel-view-css' => '23503cb9',
-    'aphront-table-view-css' => '23503cb9',
-    'aphront-tokenizer-control-css' => '23503cb9',
-    'aphront-tooltip-css' => '23503cb9',
-    'aphront-typeahead-control-css' => '23503cb9',
+    'aphront-headsup-view-css' => '77c4590d',
+    'aphront-list-filter-view-css' => '77c4590d',
+    'aphront-pager-view-css' => '77c4590d',
+    'aphront-panel-view-css' => '77c4590d',
+    'aphront-table-view-css' => '77c4590d',
+    'aphront-tokenizer-control-css' => '77c4590d',
+    'aphront-tooltip-css' => '77c4590d',
+    'aphront-typeahead-control-css' => '77c4590d',
     'differential-changeset-view-css' => 'ec01d039',
     'differential-core-view-css' => 'ec01d039',
     'differential-inline-comment-editor' => '95d0d865',
@@ -3683,7 +3683,7 @@ celerity_register_resource_map(array(
     'differential-table-of-contents-css' => 'ec01d039',
     'diffusion-commit-view-css' => 'c8ce2d88',
     'diffusion-icons-css' => 'c8ce2d88',
-    'global-drag-and-drop-css' => '23503cb9',
+    'global-drag-and-drop-css' => '77c4590d',
     'inline-comment-summary-css' => 'ec01d039',
     'javelin-aphlict' => '58743fec',
     'javelin-behavior' => '88225b70',
@@ -3753,48 +3753,48 @@ celerity_register_resource_map(array(
     'javelin-util' => '88225b70',
     'javelin-vector' => '88225b70',
     'javelin-workflow' => '88225b70',
-    'lightbox-attachment-css' => '23503cb9',
+    'lightbox-attachment-css' => '77c4590d',
     'maniphest-task-summary-css' => 'e30a3fa8',
     'maniphest-transaction-detail-css' => 'e30a3fa8',
     'phabricator-busy' => '58743fec',
     'phabricator-content-source-view-css' => 'ec01d039',
-    'phabricator-core-buttons-css' => '23503cb9',
-    'phabricator-core-css' => '23503cb9',
-    'phabricator-crumbs-view-css' => '23503cb9',
-    'phabricator-directory-css' => '23503cb9',
+    'phabricator-core-buttons-css' => '77c4590d',
+    'phabricator-core-css' => '77c4590d',
+    'phabricator-crumbs-view-css' => '77c4590d',
+    'phabricator-directory-css' => '77c4590d',
     'phabricator-drag-and-drop-file-upload' => '95d0d865',
     'phabricator-dropdown-menu' => '58743fec',
     'phabricator-file-upload' => '58743fec',
-    'phabricator-filetree-view-css' => '23503cb9',
-    'phabricator-flag-css' => '23503cb9',
-    'phabricator-form-view-css' => '23503cb9',
-    'phabricator-header-view-css' => '23503cb9',
-    'phabricator-jump-nav' => '23503cb9',
+    'phabricator-filetree-view-css' => '77c4590d',
+    'phabricator-flag-css' => '77c4590d',
+    'phabricator-form-view-css' => '77c4590d',
+    'phabricator-header-view-css' => '77c4590d',
+    'phabricator-jump-nav' => '77c4590d',
     'phabricator-keyboard-shortcut' => '58743fec',
     'phabricator-keyboard-shortcut-manager' => '58743fec',
-    'phabricator-main-menu-view' => '23503cb9',
+    'phabricator-main-menu-view' => '77c4590d',
     'phabricator-menu-item' => '58743fec',
-    'phabricator-nav-view-css' => '23503cb9',
+    'phabricator-nav-view-css' => '77c4590d',
     'phabricator-notification' => '58743fec',
-    'phabricator-notification-css' => '23503cb9',
-    'phabricator-notification-menu-css' => '23503cb9',
-    'phabricator-object-item-list-view-css' => '23503cb9',
+    'phabricator-notification-css' => '77c4590d',
+    'phabricator-notification-menu-css' => '77c4590d',
+    'phabricator-object-item-list-view-css' => '77c4590d',
     'phabricator-object-selector-css' => 'ec01d039',
     'phabricator-paste-file-upload' => '58743fec',
     'phabricator-prefab' => '58743fec',
     'phabricator-project-tag-css' => 'e30a3fa8',
-    'phabricator-remarkup-css' => '23503cb9',
+    'phabricator-remarkup-css' => '77c4590d',
     'phabricator-shaped-request' => '95d0d865',
-    'phabricator-side-menu-view-css' => '23503cb9',
-    'phabricator-standard-page-view' => '23503cb9',
+    'phabricator-side-menu-view-css' => '77c4590d',
+    'phabricator-standard-page-view' => '77c4590d',
     'phabricator-textareautils' => '58743fec',
     'phabricator-tooltip' => '58743fec',
-    'phabricator-transaction-view-css' => '23503cb9',
-    'phabricator-zindex-css' => '23503cb9',
-    'sprite-apps-large-css' => '23503cb9',
-    'sprite-gradient-css' => '23503cb9',
-    'sprite-icon-css' => '23503cb9',
-    'sprite-menu-css' => '23503cb9',
-    'syntax-highlighting-css' => '23503cb9',
+    'phabricator-transaction-view-css' => '77c4590d',
+    'phabricator-zindex-css' => '77c4590d',
+    'sprite-apps-large-css' => '77c4590d',
+    'sprite-gradient-css' => '77c4590d',
+    'sprite-icon-css' => '77c4590d',
+    'sprite-menu-css' => '77c4590d',
+    'syntax-highlighting-css' => '77c4590d',
   ),
 ));

src/applications/meta/view/PhabricatorApplicationLaunchView.php

@@ -101,7 +101,8 @@ final class PhabricatorApplicationLaunchView extends AphrontView {
           'span',
           array(
             'class' => implode(' ', $classes),
-          ));
+          ),
+          '');
 
         $create_button = phutil_render_tag(
           'a',

src/view/form/control/AphrontFormSubmitControl.php

@@ -25,6 +25,7 @@ final class AphrontFormSubmitControl extends AphrontFormControl {
       $submit_button = phutil_render_tag(
         'button',
         array(
+          'type'      => 'submit',
           'name'      => '__submit__',
           'disabled'  => $this->getDisabled() ? 'disabled' : null,
         ),

webroot/rsrc/css/core/core.css

@@ -7,6 +7,9 @@ body {
      scrollbar to a page with a scrollbar doesn't make content jump a few
      pixels left when the viewport narrows. */
   overflow-y: scroll;
+  /* reset behavior in ie7, as it will add an extra scrollbar regardless
+     selector * targets ie6 and ie7 only */
+  *overflow-y: auto;
 }
 
 .device-phone {