revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00
Code Issues Releases Wiki Activity

Fix arc patch PHP 8.1 strlen(null) error

Browse source 
Summary:
Fix arc patch PHP 8.1 strlen(null) error.

When doing an 'arc patch Dxxxx' against a diff on a PHP 8.1 Phorge server we get a strlen(null) error.
Updating the idx call to provide a default empty string resolves it.
Providing a default empty string to

Fixes T15571

Test Plan: arc patch Dxxxx

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15571

Differential Revision: https://we.phorge.it/D25364
This commit is contained in:
sten 2023-07-29 17:36:01 +01:00
parent 007e7621f2
commit 4cedb928aa
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/conduit/controller/PhabricatorConduitAPIController.php
View file

@ -289,7 +289,7 @@ final class PhabricatorConduitAPIController
);
}
$token_string = idx($metadata, 'token');
$token_string = idx($metadata, 'token', '');
if (strlen($token_string)) {
if (strlen($token_string) != 32) {

2
src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php
View file

@ -56,7 +56,7 @@ final class DifferentialGetCommitMessageConduitAPIMethod
// show "Field:" templates for some fields even if they are empty.
$edit_mode = $request->getValue('edit');
$is_any_edit = (bool)strlen($edit_mode);
$is_any_edit = (bool)$edit_mode;
$is_create = ($edit_mode == 'create');
$field_list = DifferentialCommitMessageField::newEnabledFields($viewer);