From 4d0a03e3d0b2845369e005f8c5e9fa21bc03adbe Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 12 Jan 2017 16:31:33 -0800
Subject: [PATCH] Improve commit audit status icons

Summary:
Ref T9482. These may need a little more work (feel free to shoot me a counter-diff) but try to:

  - Never use only color to distinguish between states (for colorblind, etc users).
  - Give the "nothing needs to be done" state a more obvious "okay" icon (instead of a question mark).

Test Plan: Looked at some linked commits in Maniphest, the icons made a bit more sense?

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9482

Differential Revision: https://secure.phabricator.com/D17203
---
 .../PhabricatorAuditCommitStatusConstants.php      | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php b/src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php
index 7c015efc43..bced1b2dc6 100644
--- a/src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php
+++ b/src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php
@@ -10,7 +10,7 @@ final class PhabricatorAuditCommitStatusConstants extends Phobject {
 
   public static function getStatusNameMap() {
     $map = array(
-      self::NONE                => pht('None'),
+      self::NONE                => pht('No Audits'),
       self::NEEDS_AUDIT         => pht('Audit Required'),
       self::CONCERN_RAISED      => pht('Concern Raised'),
       self::PARTIALLY_AUDITED   => pht('Partially Audited'),
@@ -46,6 +46,9 @@ final class PhabricatorAuditCommitStatusConstants extends Phobject {
       case self::FULLY_AUDITED:
         $color = 'green';
         break;
+      case self::NONE:
+        $color = 'bluegrey';
+        break;
       default:
         $color = null;
         break;
@@ -56,13 +59,18 @@ final class PhabricatorAuditCommitStatusConstants extends Phobject {
     public static function getStatusIcon($code) {
     switch ($code) {
       case self::CONCERN_RAISED:
-        $icon = 'fa-exclamation-circle';
+        $icon = 'fa-times-circle';
         break;
       case self::NEEDS_AUDIT:
-      case self::PARTIALLY_AUDITED:
         $icon = 'fa-exclamation-circle';
         break;
+      case self::PARTIALLY_AUDITED:
+        $icon = 'fa-check-circle-o';
+        break;
       case self::FULLY_AUDITED:
+        $icon = 'fa-check-circle';
+        break;
+      case self::NONE:
         $icon = 'fa-check';
         break;
       default: