revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 13:22:42 +01:00
Code Issues Releases Wiki Activity

Remove nonfunctional links from Differential inline comment previews

Browse source 
Summary:
They currently have "Next", "Previous" and "Reply" links which don't work. Don't
render these links.

Test Plan:
Looked at inline previews, didn't see any silly/nonfunctional links.

Reviewed By: tuomaspelkonen
Reviewers: aran, jungejason, tuomaspelkonen
CC: aran, epriestley, tuomaspelkonen
Differential Revision: 419
This commit is contained in:
epriestley 2011-06-09 11:09:54 -07:00
parent 2521621074
commit 4d3ef5ee0b
2 changed files with 33 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/differential/controller/inlinecommentpreview/DifferentialInlineCommentPreviewController.php
View file

@ -53,6 +53,7 @@ class DifferentialInlineCommentPreviewController
$view->setMarkupEngine($engine);
$view->setHandles($handles);
$view->setEditable(false);
$view->setPreview(true);
$views[] = $view->render();
}
$views = implode("\n", $views);

57
src/applications/differential/view/inlinecomment/DifferentialInlineCommentView.php
View file

@ -24,6 +24,7 @@ final class DifferentialInlineCommentView extends AphrontView {
private $handles;
private $markupEngine;
private $editable;
private $preview;
public function setInlineComment(DifferentialInlineComment $comment) {
$this->inlineComment = $comment;
@ -55,6 +56,10 @@ final class DifferentialInlineCommentView extends AphrontView {
return $this;
}
public function setPreview($preview) {
$this->preview = $preview;
}
public function render() {
$inline = $this->inlineComment;
@ -83,34 +88,36 @@ final class DifferentialInlineCommentView extends AphrontView {
$links = array();
$links[] = javelin_render_tag(
'a',
array(
'href' => '#',
'mustcapture' => true,
'sigil' => 'differential-inline-prev',
),
'Previous');
if (!$this->preview) {
$links[] = javelin_render_tag(
'a',
array(
'href' => '#',
'mustcapture' => true,
'sigil' => 'differential-inline-prev',
),
'Previous');
$links[] = javelin_render_tag(
'a',
array(
'href' => '#',
'mustcapture' => true,
'sigil' => 'differential-inline-next',
),
'Next');
$links[] = javelin_render_tag(
'a',
array(
'href' => '#',
'mustcapture' => true,
'sigil' => 'differential-inline-next',
),
'Next');
$links[] = javelin_render_tag(
'a',
array(
'href' => '#',
'mustcapture' => true,
'sigil' => 'differential-inline-reply',
),
'Reply');
$links[] = javelin_render_tag(
'a',
array(
'href' => '#',
'mustcapture' => true,
'sigil' => 'differential-inline-reply',
),
'Reply');
}
if ($this->editable) {
if ($this->editable && !$this->preview) {
$links[] = javelin_render_tag(
'a',
array(