revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 05:50:55 +01:00
Code Issues Releases Wiki Activity

make is to when a user resigns from an audit they are no longer cc'd

Browse source 
Summary: do this by making sure to filter out those who've "resigned" from the email CC list

Test Plan: resigned from an audit and no longer got emails on updates

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2033

Differential Revision: https://secure.phabricator.com/D3890
This commit is contained in:
Bob Trahan 2012-11-05 11:18:32 -08:00
parent ef85f49adc
commit 4d79d462fb
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/applications/audit/editor/PhabricatorAuditCommentEditor.php
View file

@ -395,16 +395,19 @@ final class PhabricatorAuditCommentEditor extends PhabricatorEditor {
$email_to[] = $author_phid;
}
$email_cc = array();
foreach ($other_comments as $other_comment) {
$email_cc[] = $other_comment->getActorPHID();
$email_cc[$other_comment->getActorPHID()] = true;
}
foreach ($requests as $request) {
if ($request->getAuditStatus() == PhabricatorAuditStatusConstants::CC) {
$email_cc[] = $request->getAuditorPHID();
$email_cc[$request->getAuditorPHID()] = true;
} else if ($request->getAuditStatus() ==
PhabricatorAuditStatusConstants::RESIGNED) {
unset($email_cc[$request->getAuditorPHID()]);
}
}
$email_cc = array_keys($email_cc);
$phids = array_merge($email_to, $email_cc);
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();