revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exception when trying to add empty user email address

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15377

Test Plan: Applied this change, afterwards repeated the steps to add a new email address on `/settings/panel/email/` and left the "Email" field empty. This time, after selecting the "Save" button, the error message "Email is required." is displayed in the "New Address" overlay dialog.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15377

Differential Revision: https://we.phorge.it/D25211
This commit is contained in:
Andre Klapper 2023-05-10 10:28:50 +02:00
parent c86364c2aa
commit 4d97195397
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php
View file

@ -184,7 +184,7 @@ final class PhabricatorEmailAddressesSettingsPanel
new PhabricatorSettingsAddEmailAction(), new PhabricatorSettingsAddEmailAction(),
1); 1);
if (!strlen($email)) { if (!phutil_nonempty_string($email)) {
$e_email = pht('Required'); $e_email = pht('Required');
$errors[] = pht('Email is required.'); $errors[] = pht('Email is required.');
} else if (!PhabricatorUserEmail::isValidAddress($email)) { } else if (!PhabricatorUserEmail::isValidAddress($email)) {