revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 13:22:42 +01:00
Code Issues Releases Wiki Activity

Don't use CommentEditor in lipsum

Browse source 
Summary: Ref T2222. For now, I'm just dropping this rather than updating it since I'll need to come back here later for `DifferentialRevisionEditor` anyway, and no users rely on this functionality.

Test Plan: Static checks; this isn't user-facing.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8426
This commit is contained in:
epriestley 2014-03-07 08:10:07 -08:00
parent 75514cc0f7
commit 4dfd4944c4
1 changed files with 4 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php
View file

@ -19,18 +19,10 @@ final class PhabricatorDifferentialRevisionTestDataGenerator
$editor->addDiff($diff, $this->generateDescription()); $editor->addDiff($diff, $this->generateDescription());
$editor->setAuxiliaryFields($aux_fields); $editor->setAuxiliaryFields($aux_fields);
$editor->save(); $editor->save();
// Add Reviewers
$editor2 = new DifferentialCommentEditor($revision, // TODO: After T2222, it would be nice to revisit this and expand the
DifferentialAction::ACTION_ADDREVIEWERS); // functionality.
$editor2->setActor($author);
$editor2->setAddedReviewers($this->getCCPHIDs());
$editor2->save();
// Add CCs
$editor3 = new DifferentialCommentEditor($revision,
DifferentialAction::ACTION_ADDCCS);
$editor3->setActor($author);
$editor3->setAddedCCs($this->getCCPHIDs());
$editor3->save();
return $revision->save(); return $revision->save();
} }