From 4e348bb04d79b8870b17bb1c4f6bc2768b779765 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Wed, 18 Feb 2015 15:43:09 -0800 Subject: [PATCH] Remove extra space under PHUIActionPanel Summary: If we don't have a state in PHUIActionPanelView, don't set the extra padding to display it. Test Plan: Review in UIExamples. Reviewers: epriestley, btrahan Reviewed By: btrahan Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11814 --- resources/celerity/map.php | 4 ++-- src/view/phui/PHUIActionPanelView.php | 2 ++ webroot/rsrc/css/phui/phui-action-panel.css | 3 +++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 3c9da6215e..6bc1dba566 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -122,7 +122,7 @@ return array( 'rsrc/css/phui/calendar/phui-calendar.css' => '8675968e', 'rsrc/css/phui/phui-action-header-view.css' => '89c497e7', 'rsrc/css/phui/phui-action-list.css' => '9ee9910a', - 'rsrc/css/phui/phui-action-panel.css' => '4bcb288d', + 'rsrc/css/phui/phui-action-panel.css' => 'd2e088bd', 'rsrc/css/phui/phui-box.css' => '7b3a2eed', 'rsrc/css/phui/phui-button.css' => 'ffe12633', 'rsrc/css/phui/phui-crumbs-view.css' => '594d719e', @@ -771,7 +771,7 @@ return array( 'phrequent-css' => 'ffc185ad', 'phriction-document-css' => '7d7f0071', 'phui-action-header-view-css' => '89c497e7', - 'phui-action-panel-css' => '4bcb288d', + 'phui-action-panel-css' => 'd2e088bd', 'phui-box-css' => '7b3a2eed', 'phui-button-css' => 'ffe12633', 'phui-calendar-css' => '8675968e', diff --git a/src/view/phui/PHUIActionPanelView.php b/src/view/phui/PHUIActionPanelView.php index 822352e05e..68350d7603 100644 --- a/src/view/phui/PHUIActionPanelView.php +++ b/src/view/phui/PHUIActionPanelView.php @@ -83,7 +83,9 @@ final class PHUIActionPanelView extends AphrontTagView { $classes = array(); $classes[] = 'phui-action-panel'; if ($this->state) { + $classes[] = 'phui-action-panel-has-state'; $classes[] = $this->state; + } return array( diff --git a/webroot/rsrc/css/phui/phui-action-panel.css b/webroot/rsrc/css/phui/phui-action-panel.css index e3f18be7bf..ba799253b8 100644 --- a/webroot/rsrc/css/phui/phui-action-panel.css +++ b/webroot/rsrc/css/phui/phui-action-panel.css @@ -4,6 +4,9 @@ .phui-action-panel { position: relative; +} + +.phui-action-panel-has-state.phui-action-panel { padding-bottom: 44px; }