1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00

Transactions - fix edit submit URI

Summary:
tracing this a bit, in core/behavior-form.js we end up doing form.submit() on this form. Before this patch, the form had no submitURI set so it ended up doing a page load. Now, we set the submitURI and (at least) the form is actually submitted and data is saved. Ref T4669.

Not sure how come the syntheticSubmit even isn't getting picked up though?

Test Plan: hit apple + enter to submit comment edit. page reloaded and my edit persisted!

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T4669

Differential Revision: https://secure.phabricator.com/D8952
This commit is contained in:
Bob Trahan 2014-05-02 09:37:34 -07:00
parent 97f88f468b
commit 4e4a520b78

View file

@ -60,6 +60,8 @@ final class PhabricatorApplicationTransactionCommentEditController
$dialog = id(new AphrontDialogView())
->setUser($user)
->setSubmitURI(
$this->getApplicationURI('/transactions/edit/'.$xaction->getPHID().'/'))
->setTitle(pht('Edit Comment'));
$dialog