revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 00:10:57 +01:00
Code Issues Releases Wiki Activity

Make naming, titles and layout more consistent between Maniphest and

Browse source 
Differential

Summary:
Make some display stuff more consistent.

Test Plan:
Looked at a task and a revision.

Reviewed By: jungejason
Reviewers: aran, jungejason, tuomaspelkonen
CC: aran, jungejason
Differential Revision: 462
This commit is contained in:
epriestley 2011-06-14 12:53:52 -07:00
parent 921164aab7
commit 4e75080b66
5 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php
View file

@ -242,7 +242,7 @@ class DifferentialRevisionViewController extends DifferentialController {
$changeset_view->render(). $changeset_view->render().
$comment_form->render()), $comment_form->render()),
array( array(
'title' => $revision->getTitle(), 'title' => 'D'.$revision->getID().' '.$revision->getTitle(),
)); ));
} }

7
src/applications/differential/view/revisiondetail/DifferentialRevisionDetailView.php
View file

@ -86,7 +86,12 @@ final class DifferentialRevisionDetailView extends AphrontView {
id(new AphrontKeyboardShortcutsAvailableView())->render(). id(new AphrontKeyboardShortcutsAvailableView())->render().
'</div>'. '</div>'.
'<div class="differential-revision-detail-core">'. '<div class="differential-revision-detail-core">'.
'<h1>'.phutil_escape_html($revision->getTitle()).'</h1>'. '<h1>'.
'<span class="aphront-headsup-object-name">'.
phutil_escape_html('D'.$revision->getID()).
'</span>'.
' '.
phutil_escape_html($revision->getTitle()).'</h1>'.
$properties. $properties.
'</div>'. '</div>'.
'<div style="clear: both;"></div>'. '<div style="clear: both;"></div>'.

6
src/applications/maniphest/controller/taskdetail/ManiphestTaskDetailController.php
View file

@ -196,7 +196,11 @@ class ManiphestTaskDetailController extends ManiphestController {
$action_list->render(). $action_list->render().
'<div class="maniphest-task-detail-core">'. '<div class="maniphest-task-detail-core">'.
'<h1>'. '<h1>'.
phutil_escape_html('T'.$task->getID().' '.$task->getTitle()). '<span class="aphront-headsup-object-name">'.
phutil_escape_html('T'.$task->getID()).
'</span>'.
' '.
phutil_escape_html($task->getTitle()).
'</h1>'. '</h1>'.
$table. $table.
'</div>'. '</div>'.

4
webroot/rsrc/css/aphront/headsup-action-list-view.css
View file

@ -2,6 +2,10 @@
* @provides aphront-headsup-action-list-view-css * @provides aphront-headsup-action-list-view-css
*/ */
.aphront-headsup-object-name {
color: #666666;
margin-right: 0.25em;
}
.aphront-headsup-action-list { .aphront-headsup-action-list {
float: right; float: right;

2
webroot/rsrc/css/application/differential/core.css
View file

@ -3,7 +3,7 @@
*/ */
.differential-primary-pane { .differential-primary-pane {
margin: 0 40px; margin: 0 0 0 2em;
padding-bottom: 2em; padding-bottom: 2em;
/** /**