revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00
Code Issues Releases Wiki Activity

Convert SavedQuery / NamedQuery to text, not bytes

Browse source 
Summary: Ref T1191. Similar issue to D10613. This column usually has a hash exactly 12 bytes long, but sometimes stores an internal builtin query name like "open", "all", etc. It might be nice to promote those to 12-byte hashes of a consistent length eventually, but for now just make this a variable-length column.

Test Plan: Ran migration, no longer saw issues with reordering builtin saved searches.

Reviewers: btrahan

Subscribers: epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10614
This commit is contained in:
epriestley 2014-10-01 10:11:19 -07:00
parent f881b5dd7f
commit 4eb4399640
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/search/storage/PhabricatorNamedQuery.php
View file

@ -17,7 +17,7 @@ final class PhabricatorNamedQuery extends PhabricatorSearchDAO
self::CONFIG_COLUMN_SCHEMA => array( self::CONFIG_COLUMN_SCHEMA => array(
'engineClassName' => 'text128', 'engineClassName' => 'text128',
'queryName' => 'text255', 'queryName' => 'text255',
'queryKey' => 'bytes12', 'queryKey' => 'text12',
'isBuiltin' => 'bool', 'isBuiltin' => 'bool',
'isDisabled' => 'bool', 'isDisabled' => 'bool',
'sequence' => 'uint32', 'sequence' => 'uint32',

2
src/applications/search/storage/PhabricatorSavedQuery.php
View file

@ -14,7 +14,7 @@ final class PhabricatorSavedQuery extends PhabricatorSearchDAO
), ),
self::CONFIG_COLUMN_SCHEMA => array( self::CONFIG_COLUMN_SCHEMA => array(
'engineClassName' => 'text255', 'engineClassName' => 'text255',
'queryKey' => 'bytes12', 'queryKey' => 'text12',
), ),
self::CONFIG_KEY_SCHEMA => array( self::CONFIG_KEY_SCHEMA => array(
'key_queryKey' => array( 'key_queryKey' => array(