From 4f40cb0ff9c6c28596fce62d0f3f5a87a8d44a72 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 11 Feb 2019 06:55:23 -0800 Subject: [PATCH] (stable) Fix inverted check in audit triggers for "uninvolved owner" Summary: See D20126. I was trying to be a little too cute here with the names and ended up confusing myself, then just tested the method behavior. :/ Test Plan: Persudaded by arguments in D20126. Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D20135 --- .../worker/PhabricatorRepositoryCommitOwnersWorker.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php b/src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php index b0c60667a4..d5054a7f18 100644 --- a/src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php +++ b/src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php @@ -174,12 +174,12 @@ final class PhabricatorRepositoryCommitOwnersWorker // If auditing is configured to trigger on changes with no involved owner, // check for an owner. If we don't find one, trigger an audit. if ($audit_uninvolved) { - $commit_uninvolved = $this->isOwnerInvolved( + $owner_involved = $this->isOwnerInvolved( $commit, $package, $author_phid, $revision); - if ($commit_uninvolved) { + if (!$owner_involved) { return true; } }