Add some descriptive properties when viewing a Calendar import

Summary: Ref T10747. When viewing an import detail page, show a little more information about what you're looking at.

Test Plan: {F1876957}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16726

src/applications/calendar/controller/PhabricatorCalendarImportViewController.php

@@ -151,6 +151,17 @@ final class PhabricatorCalendarImportViewController
     $properties = id(new PHUIPropertyListView())
       ->setViewer($viewer);
 
+    $engine = $import->getEngine();
+
+    $properties->addProperty(
+      pht('Source Type'),
+      $engine->getImportEngineTypeName());
+
+    $engine->appendImportProperties(
+      $viewer,
+      $import,
+      $properties);
+
     return $properties;
   }
 

src/applications/calendar/import/PhabricatorCalendarICSImportEngine.php

@@ -9,10 +9,28 @@ final class PhabricatorCalendarICSImportEngine
     return pht('Import .ics File');
   }
 
+  public function getImportEngineTypeName() {
+    return pht('.ics File');
+  }
+
   public function getImportEngineHint() {
     return pht('Import an event in ".ics" (iCalendar) format.');
   }
 
+
+  public function appendImportProperties(
+    PhabricatorUser $viewer,
+    PhabricatorCalendarImport $import,
+    PHUIPropertyListView $properties) {
+
+    $phid_key = PhabricatorCalendarImportICSFileTransaction::PARAMKEY_FILE;
+    $file_phid = $import->getParameter($phid_key);
+
+    $properties->addProperty(
+      pht('Source File'),
+      $viewer->renderHandle($file_phid));
+  }
+
   public function newEditEngineFields(
     PhabricatorEditEngine $engine,
     PhabricatorCalendarImport $import) {

src/applications/calendar/import/PhabricatorCalendarImportEngine.php

@@ -9,8 +9,16 @@ abstract class PhabricatorCalendarImportEngine
 
 
   abstract public function getImportEngineName();
+  abstract public function getImportEngineTypeName();
   abstract public function getImportEngineHint();
 
+  public function appendImportProperties(
+    PhabricatorUser $viewer,
+    PhabricatorCalendarImport $import,
+    PHUIPropertyListView $properties) {
+    return;
+  }
+
   abstract public function newEditEngineFields(
     PhabricatorEditEngine $engine,
     PhabricatorCalendarImport $import);