revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exception rendering files/documents

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php:211]
```

Closes T15826

Test Plan: Surf a Diffusion repository and play with {nav View Options}.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15826

Differential Revision: https://we.phorge.it/D25638
This commit is contained in:
Andre Klapper 2024-05-13 19:48:38 +02:00
parent 464a0aedc4
commit 50d0bbe8ff
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php
View file

@ -208,12 +208,12 @@ abstract class PhabricatorDocumentRenderingEngine
$this->activeEngine = $engine; $this->activeEngine = $engine;
$encode_setting = $request->getStr('encode'); $encode_setting = $request->getStr('encode');
if (strlen($encode_setting)) { if (phutil_nonempty_string($encode_setting)) {
$engine->setEncodingConfiguration($encode_setting); $engine->setEncodingConfiguration($encode_setting);
} }
$highlight_setting = $request->getStr('highlight'); $highlight_setting = $request->getStr('highlight');
if (strlen($highlight_setting)) { if (phutil_nonempty_string($highlight_setting)) {
$engine->setHighlightingConfiguration($highlight_setting); $engine->setHighlightingConfiguration($highlight_setting);
} }