From 51268de15fe1a1d7c39d52500fbcb3ff2f095bc7 Mon Sep 17 00:00:00 2001
From: Aviv Eyal <avivey@gmail.com>
Date: Sat, 5 Dec 2015 22:34:03 +0000
Subject: [PATCH] Fix Versions page

Summary:
- ipull there is wrong
- The `+` wasn't doing what I thought it was doing.
- I already forgot what that detour was doing, so I wrote it down.

Test Plan: Load Versions page, see no error log.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D14686
---
 .../config/module/PhabricatorConfigVersionsModule.php       | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/applications/config/module/PhabricatorConfigVersionsModule.php b/src/applications/config/module/PhabricatorConfigVersionsModule.php
index 611c332eb0..9a6292a9ef 100644
--- a/src/applications/config/module/PhabricatorConfigVersionsModule.php
+++ b/src/applications/config/module/PhabricatorConfigVersionsModule.php
@@ -45,9 +45,9 @@ final class PhabricatorConfigVersionsModule
     );
 
     $all_libraries = PhutilBootloader::getInstance()->getAllLibraries();
-    $other_libraries = array_diff($all_libraries, ipull($specs, 'lib'));
-    $specs = $specs + $other_libraries;
-
+    // This puts the core libraries at the top:
+    $other_libraries = array_diff($all_libraries, $specs);
+    $specs = array_merge($specs, $other_libraries);
 
     $futures = array();
     foreach ($specs as $lib) {